feat(lefthook): make feature installed after git

Author: kucingkode

src/lefthook/devcontainer-feature.json

@@ -1,7 +1,7 @@
 {
     "name": "Lefthook",
     "id": "lefthook",
-    "version": "1.0.1",
+    "version": "1.0.2",
     "documentationURL": "http://github.com/omoxyz/devcontainer-features/tree/main/src/lefthook",
     "description": "Install Lefthook fast polyglot Git hooks manager.",
     "options": {
@@ -18,5 +18,8 @@
             "description": "Install directly from Github release or from package manager (apt).",
             "default": true
         }
-    }
+    },
+    "installsAfter": [
+        "ghcr.io/devcontainers/features/git"
+    ]
 }

src/lefthook/install.sh

@@ -1,5 +1,10 @@
 #!/usr/bin/env bash
 
+if [ "$(id -u)" -ne 0 ]; then
+    echo -e 'Scripts must be run as root. Use sudo, su, or add "USER root" to your Dockerfile before running this script.'
+    exit 1
+fi
+
 source ./utils.sh
 
 LEFTHOOK_VERSION=${VERSION:-"latest"}
@@ -14,11 +19,6 @@ apt_get_update
 # Clean up
 rm -rf /var/lib/apt/lists/*
 
-if [ "$(id -u)" -ne 0 ]; then
-    echo -e 'Scripts must be run as root. Use sudo, su, or add "USER root" to your Dockerfile before running this script.'
-    exit 1
-fi
-
 export DEBIAN_FRONTEND=noninteractive
 
 get_github_filename() {
@@ -39,19 +39,23 @@ install_from_github() {
     latest_version=${versions[0]}
     prev_version=${versions[1]}
 
+
     echo "Downloading lefthook v${latest_version}...."
 
     check_packages wget
     local arch=$(dpkg --print-architecture)
 
     local filename=$(get_github_filename $latest_version $arch)
 
+    set +e
+
     mkdir -p /tmp/lefthook
     pushd /tmp/lefthook
     wget ${GITHUB_REPO}/releases/download/v${latest_version}/${filename}
     local exit_code=$?
 
     set -e
+
     if [ "$exit_code" != "0" ]; then
         # Handle situation where git tags are ahead of what was is available to actually download
         echo "(!) lefthook version ${latest_version} failed to download. Attempting to fall back to ${prev_version} to retry..."