replace all printf, frpintfs in libnvme

[igaw]

The struct nvme_global_ctx is available everywhere (if not add it to the fucntion).
Use it replace the printf/fprintf error logging:

	err = nvme_submit_admin_passthru(hdl, &cmd);
	if (err) {
		fprintf(stderr, "ERROR: nvme_identify_ctrl() failed 0x%x\n", err);
		return err;
	}

[ikegami-t]

How can we use the struct nvme_global_ctx instead of the printf and fprintf in linbvme for the error outputs?

[igaw]

yes, that's the idea. all printf, fprintfs should use the nvme_msg with the global context object. I am currently working on adding the global context to all functions. There some refactoring necessary to make this neat. I hope to get this point soon where we can do this task here.

If you want to change the printf/fprintf where we already have the global context, please don't let me stop you. I would just recommend not to work on updating the API with the global context. This will collide with my work.

[ikegami-t]

Understood. Thank you.

[ikegami-t]

Currently nvme_msg() is defined in private.h and also __nvme_msg() used by the definition is not added in libnvme.ld then can not be used yet so do we need to wait nvme_msg() as added in libnvme.ld?
(Added)
Just tested nvme_msg() with the patch nvme-msg.patch attached then confirm as for the normal outpout LOG_ERR needed to set but LOG_INFO is not output without the -v option. By the way seems __nvme_msg() always output to stdout but not output to stderr but is this expected?

[igaw]

nvme_msg and __nvme_msg should not be exported. These two function are really for the library to use. Not sure what you want to achieve by making them public?

[ikegami-t]

Thanks for your comment. Just realized this issue only for the printf and fprintf functions in libnvme but not only for nvme-cli itself as mentioend by the issue title so will do fix as so later.

[igaw]

Ah, yes, this change is indeed only for libnvme. nvme-cli can use printf etc.

We might still need to do some more cleanup in nvme-cli with printing, as we should really output the right format (e.g. json when selected). But this is a different task.

[ikegami-t]

Just created the PR: linux-nvme#3098.

[igaw]

Looks pretty good, thanks! There a few more places which need to be updated:

• validate_uri in fabrics.c
• json_update_config (the printf("\n") is wrong), in fact json.c should just use the provided filedescriptor from parse_json and not stdout .

With this we should be done with this tasks :)

[ikegami-t]

Let me confirm below. Thank you.

1. validate_uri is not available with the struct nvme_global_ctx but still needed to be updated really?
2. json_update_config is available with the struct nvme_global_ctx but nvme_msg needed to output by default with the LOG_ERR (and not output with the LOG_INFO and LOG_DEBUG) but still needed to be updated really?

[igaw]

validate_uri is still using printfs, that's wrong. It should use nvme_msg. For this the struct nvme_global_ctx needs to be passed in.

json_update_config should use fprintf(fd, "\n").

[ikegami-t]

I see. Thank you for your advice.

[ikegami-t]

Pushed the PR: linux-nvme#3099 and for the json_update_config used dprintf(1, "\n") instead of fprintf(fd, "\n") as review commented on the PR. Note: If needed I can do change the hardcoded fd value 1 to STDOUT_FILENO. By the way can we change the nvme_msg to add functionality to output by default without the LOG_ERR?