Commit 4c11b62
authored
chore(misc): fix NPM audit by removing unused faro deps and stale patch (#35368)
## Current Behavior
The scheduled `NPM Audit` workflow is failing on `master` due to a
critical advisory
([GHSA-xq3m-2v4x-88gg](GHSA-xq3m-2v4x-88gg))
in `[email protected]`, pulled in transitively via:
```
@grafana/faro-web-sdk > @grafana/faro-core > @opentelemetry/otlp-transformer > protobufjs
```
Failing run: https://github.com/nrwl/nx/actions/runs/24753360724
Separately, the workspace carries a `@nx/[email protected]` patch even
though the workspace is on `22.7.0-beta.16`, and `allowUnusedPatches:
true` was set in `pnpm-workspace.yaml` to suppress the warning.
## Expected Behavior
- `NPM Audit` workflow passes.
- No stale patches, and unused patches fail loudly rather than being
silently allowed.
### Changes
1. **Remove `@grafana/faro-web-sdk` and `@grafana/faro-web-tracing`.** A
`git grep` confirms neither package is imported anywhere in the codebase
— they were listed in `package.json` but unused. Removing them drops the
transitive `[email protected]` entirely and clears the critical advisory
(audit verified locally).
2. **Delete the stale `@nx/[email protected]` patch and drop
`allowUnusedPatches: true`** from `pnpm-workspace.yaml` so future stale
patches surface immediately.
## Related Issue(s)
N/A (fixes failing scheduled CI workflow).1 parent 362ff61 commit 4c11b62
4 files changed
Lines changed: 2 additions & 378 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
353 | 353 | | |
354 | 354 | | |
355 | 355 | | |
356 | | - | |
357 | | - | |
358 | 356 | | |
359 | 357 | | |
360 | 358 | | |
| |||
This file was deleted.
0 commit comments