fix: open docs links in the same tab closes #6927 (#6936)

wesleytodd · web-flow · commit d2f278a18966 · 2024-07-27T03:27:58.000Z
* fix: open docs links in the same tab closes #6927 * fix: update link display logic instead of the href
diff --git a/apps/site/components/Containers/NavBar/NavItem/index.tsx b/apps/site/components/Containers/NavBar/NavItem/index.tsx
@@ -31,9 +31,7 @@ const NavItem: FC<PropsWithChildren<NavItemProps>> = ({
   >
     <span className={styles.label}>{children}</span>
 
-    {((type === 'nav' && href.startsWith('http')) || target === '_blank') && (
-      <ArrowUpRightIcon className={styles.icon} />
-    )}
+    {target === '_blank' && <ArrowUpRightIcon className={styles.icon} />}
   </ActiveLink>
 );
 
diff --git a/apps/site/navigation.json b/apps/site/navigation.json
@@ -18,8 +18,7 @@
     },
     "docs": {
       "link": "https://nodejs.org/docs/latest/api/",
-      "label": "components.containers.navBar.links.docs",
-      "target": "_blank"
+      "label": "components.containers.navBar.links.docs"
     },
     "certification": {
       "link": "https://training.linuxfoundation.org/openjs/",

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,7 @@ const NavItem: FC<PropsWithChildren<NavItemProps>> = ({`
`31`	`31`	`>`
`32`	`32`	`<span className={styles.label}>{children}</span>`
`33`	`33`
`34`		`- {((type === 'nav' && href.startsWith('http')) \|\| target === '_blank') && (`
`35`		`- <ArrowUpRightIcon className={styles.icon} />`
`36`		`- )}`
	`34`	`+ {target === '_blank' && <ArrowUpRightIcon className={styles.icon} />}`
`37`	`35`	`</ActiveLink>`
`38`	`36`	`);`
`39`	`37`