fix: erroneous env usage for fetch

Author: ovflowd

apps/site/next-data/blogData.ts

@@ -1,22 +1,17 @@
 import {
   ENABLE_STATIC_EXPORT,
-  IS_DEVELOPMENT,
+  IS_DEV_ENV,
   NEXT_DATA_URL,
   VERCEL_ENV,
 } from '@/next.constants.mjs';
 import type { BlogPostsRSC } from '@/types';
 
-// Prevents React from throwing an Error when not able to fulfil a request
-// due to missing category or internal processing errors
-const parseBlogDataResponse = (data: string): BlogPostsRSC =>
-  data.startsWith('{') ? JSON.parse(data) : { posts: [], pagination: {} };
-
 const getBlogData = (cat: string, page?: number): Promise<BlogPostsRSC> => {
   // When we're using Static Exports the Next.js Server is not running (during build-time)
   // hence the self-ingestion APIs will not be available. In this case we want to load
   // the data directly within the current thread, which will anyways be loaded only once
   // We use lazy-imports to prevent `provideBlogData` from executing on import
-  if (ENABLE_STATIC_EXPORT || (!IS_DEVELOPMENT && !VERCEL_ENV)) {
+  if (ENABLE_STATIC_EXPORT || (VERCEL_ENV !== 'production' && !IS_DEV_ENV)) {
     return import('@/next-data/providers/blogData').then(
       ({ provideBlogPosts, providePaginatedBlogPosts }) =>
         page ? providePaginatedBlogPosts(cat, page) : provideBlogPosts(cat)
@@ -29,7 +24,7 @@ const getBlogData = (cat: string, page?: number): Promise<BlogPostsRSC> => {
   // outdated information being shown to the user.
   return fetch(fetchURL)
     .then(response => response.text())
-    .then(response => parseBlogDataResponse(response));
+    .then(JSON.parse);
 };
 
 export default getBlogData;

apps/site/next-data/downloadSnippets.ts

@@ -1,17 +1,12 @@
 import {
   ENABLE_STATIC_EXPORT,
-  IS_DEVELOPMENT,
+  IS_DEV_ENV,
   NEXT_DATA_URL,
   VERCEL_ENV,
 } from '@/next.constants.mjs';
 import { availableLocaleCodes } from '@/next.locales.mjs';
 import type { DownloadSnippet } from '@/types';
 
-// Prevents React from throwing an Error when not able to fulfil a request
-// due to internal processing errors
-const parseDownloadSnippetResponse = (data: string): Array<DownloadSnippet> =>
-  data.startsWith('{') ? JSON.parse(data) : [];
-
 const getDownloadSnippets = (lang: string): Promise<Array<DownloadSnippet>> => {
   // Prevents attempting to retrieve data for an unsupported language as both the generator
   // and the API endpoint will simply return 404. And we want to prevent a 404 response.
@@ -23,7 +18,7 @@ const getDownloadSnippets = (lang: string): Promise<Array<DownloadSnippet>> => {
   // hence the self-ingestion APIs will not be available. In this case we want to load
   // the data directly within the current thread, which will anyways be loaded only once
   // We use lazy-imports to prevent `provideBlogData` from executing on import
-  if (ENABLE_STATIC_EXPORT || (!IS_DEVELOPMENT && !VERCEL_ENV)) {
+  if (ENABLE_STATIC_EXPORT || (VERCEL_ENV !== 'production' && !IS_DEV_ENV)) {
     return import('@/next-data/providers/downloadSnippets').then(
       ({ default: provideDownloadSnippets }) => provideDownloadSnippets(lang)!
     );
@@ -43,7 +38,7 @@ const getDownloadSnippets = (lang: string): Promise<Array<DownloadSnippet>> => {
   // that does not provide a clear stack trace of which request is failing and what the JSON.parse error is
   return fetch(fetchURL)
     .then(response => response.text())
-    .then(response => parseDownloadSnippetResponse(response));
+    .then(JSON.parse);
 };
 
 export default getDownloadSnippets;

apps/site/next-data/releaseData.ts

@@ -1,6 +1,6 @@
 import {
   ENABLE_STATIC_EXPORT,
-  IS_DEVELOPMENT,
+  IS_DEV_ENV,
   NEXT_DATA_URL,
   VERCEL_ENV,
 } from '@/next.constants.mjs';
@@ -11,7 +11,7 @@ const getReleaseData = (): Promise<Array<NodeRelease>> => {
   // hence the self-ingestion APIs will not be available. In this case we want to load
   // the data directly within the current thread, which will anyways be loaded only once
   // We use lazy-imports to prevent `provideBlogData` from executing on import
-  if (ENABLE_STATIC_EXPORT || (!IS_DEVELOPMENT && !VERCEL_ENV)) {
+  if (ENABLE_STATIC_EXPORT || (VERCEL_ENV !== 'production' && !IS_DEV_ENV)) {
     return import('@/next-data/providers/releaseData').then(
       ({ default: provideReleaseData }) => provideReleaseData()
     );

apps/site/next.constants.mjs

@@ -3,7 +3,7 @@
 /**
  * This is used to verify if the current Website is running on a Development Environment
  */
-export const IS_DEVELOPMENT = process.env.NODE_ENV === 'development';
+export const IS_DEV_ENV = process.env.NODE_ENV === 'development';
 
 /**
  * This is used for telling Next.js if the Website is deployed on Vercel

apps/site/next.dynamic.mjs

@@ -12,7 +12,7 @@ import {
   BASE_URL,
   DEFAULT_CATEGORY_OG_TYPE,
   ENABLE_STATIC_EXPORT,
-  IS_DEVELOPMENT,
+  IS_DEV_ENV,
 } from './next.constants.mjs';
 import {
   DYNAMIC_ROUTES,
@@ -42,7 +42,7 @@ const mapPathToRoute = (locale = defaultLocale.code, path = '') => ({
 // Provides an in-memory Map that lasts the whole build process
 // and disabled when on development mode (stubbed)
 const createCachedMarkdownCache = () => {
-  if (IS_DEVELOPMENT) {
+  if (IS_DEV_ENV) {
     return {
       has: () => false,
       set: () => {},