rename ref to url

Author: avivkeller

apps/site/components/EOL/VulnerabilitiesTable/index.tsx

@@ -51,9 +51,9 @@ const VulnerabilitiesTable: FC<{
               {vulnerability.description || vulnerability.overview || '-'}
             </td>
             <td>
-              {vulnerability.ref ? (
+              {vulnerability.url ? (
                 <LinkWithArrow
-                  href={vulnerability.ref}
+                  href={vulnerability.url}
                   target="_blank"
                   rel="noopener noreferrer"
                 >

apps/site/components/EOL/VulnerabilityChips/Chip/index.tsx

@@ -3,10 +3,15 @@ import { useTranslations } from 'next-intl';
 import type { FC } from 'react';
 
 import { SEVERITY_KIND_MAP } from '#site/next.constants.mjs';
-import type { VulnerabilityChipProps } from '#site/types';
+import type { Severity } from '#site/types';
 
 import styles from './index.module.css';
 
+type VulnerabilityChipProps = {
+  severity: Severity;
+  count?: number;
+};
+
 const VulnerabilityChip: FC<VulnerabilityChipProps> = ({
   severity,
   count = 0,

apps/site/components/EOL/VulnerabilityChips/index.tsx

@@ -2,7 +2,11 @@ import type { FC } from 'react';
 
 import VulnerabilityChip from '#site/components/EOL/VulnerabilityChips/Chip';
 import { SEVERITY_ORDER } from '#site/next.constants.mjs';
-import type { Severity, VulnerabilityChipsProps } from '#site/types';
+import type { Severity, Vulnerability } from '#site/types';
+
+type VulnerabilityChipsProps = {
+  vulnerabilities: Array<Vulnerability>;
+};
 
 const VulnerabilityChips: FC<VulnerabilityChipsProps> = ({
   vulnerabilities,

apps/site/next-data/generators/vulnerabilities.mjs

@@ -9,6 +9,10 @@ export function groupVulnerabilitiesByMajor(vulnerabilities) {
   const grouped = {};
 
   for (const vulnerability of vulnerabilities) {
+    // To avoid future confusion, rename 'ref' to 'url'
+    vulnerability.url = vulnerability.ref;
+    delete vulnerability.ref;
+
     // split on '||' to handle multiple versions and trim whitespace
     const potentialVersions =
       vulnerability.vulnerable?.split('||').map(v => v.trim()) || [];

apps/site/types/vulnerabilities.ts

@@ -1,9 +1,7 @@
-import type { NodeRelease } from '#site/types';
-
 export type Severity = 'unknown' | 'low' | 'medium' | 'high' | 'critical';
 export interface Vulnerability {
   cve: Array<string>;
-  ref?: string;
+  url?: string;
   vulnerable: string;
   patched?: string;
   description: string;
@@ -15,17 +13,3 @@ export interface Vulnerability {
 export interface GroupedVulnerabilities {
   [majorVersion: string]: Array<Vulnerability>;
 }
-
-export type VulnerabilityChipsProps = {
-  vulnerabilities: Array<Vulnerability>;
-};
-
-export type VulnerabilityChipProps = {
-  severity: Severity;
-  count?: number;
-};
-
-export type EOLModalData = {
-  release: NodeRelease;
-  vulnerabilities: Array<Vulnerability>;
-};