chore: type organisation

Author: canerakdas

apps/site/types/download.ts

@@ -1,7 +1,41 @@
+import type { SelectValue } from '@node-core/ui-components/Common/Select';
+
+import type {
+  IntlMessageKeys,
+  NodeReleaseStatus,
+  OperatingSystem,
+  Platform,
+} from '#site/types';
+
 export interface DownloadSnippet {
   name: string;
   language: string;
   content: string;
 }
 
 export type DownloadKind = 'installer' | 'binary' | 'source' | 'shasum';
+
+type DownloadCompatibility = {
+  os?: Array<OperatingSystem | 'LOADING'>;
+  installMethod?: Array<string>;
+  platform?: Array<Platform | ''>;
+  semver?: Array<string>;
+  releases?: Array<NodeReleaseStatus>;
+};
+
+export type DownloadDropdownItem<T extends string> = {
+  label: IntlMessageKeys;
+  recommended?: boolean;
+  url?: string;
+  info?: IntlMessageKeys;
+  compatibility: DownloadCompatibility;
+} & Omit<SelectValue<T>, 'label'>;
+
+export type NodeDownloadArtifact = {
+  file: string;
+  kind: DownloadKind;
+  os: OperatingSystem;
+  architecture: string;
+  url: string;
+  version: string;
+};

apps/site/util/download/archive.tsx

@@ -1,22 +1,18 @@
 import semVer from 'semver';
 
-import type { DownloadKind, OperatingSystem, Platform } from '#site/types';
+import type {
+  DownloadDropdownItem,
+  DownloadKind,
+  NodeDownloadArtifact,
+  OperatingSystem,
+  Platform,
+} from '#site/types';
 import type { NodeRelease } from '#site/types/releases';
-import type { DownloadDropdownItem } from '#site/util/download';
 import { OS_NOT_SUPPORTING_INSTALLERS, PLATFORMS } from '#site/util/download';
 import { getNodeDownloadUrl } from '#site/util/url';
 
 import { DIST_URL } from '#site/next.constants';
 
-export type NodeDownloadArtifact = {
-  file: string;
-  kind: DownloadKind;
-  os: OperatingSystem;
-  architecture: string;
-  url: string;
-  version: string;
-};
-
 /**
  * Checks if a download item is compatible with the given OS, platform, and version.
  */

apps/site/util/download/index.tsx

@@ -1,11 +1,11 @@
-import type { SelectValue } from '@node-core/ui-components/Common/Select';
 import * as InstallMethodIcons from '@node-core/ui-components/Icons/InstallationMethod';
 import * as OSIcons from '@node-core/ui-components/Icons/OperatingSystem';
 import * as PackageManagerIcons from '@node-core/ui-components/Icons/PackageManager';
 import type { ElementType } from 'react';
 import satisfies from 'semver/functions/satisfies';
 
 import type {
+  DownloadDropdownItem,
   IntlMessageKeys,
   NodeReleaseStatus,
   OperatingSystem,
@@ -27,23 +27,6 @@ export const OperatingSystemLabel = Object.fromEntries(
   Object.entries(systems).map(([key, data]) => [key, data.name])
 );
 
-// Base types for dropdown functionality
-type DownloadCompatibility = {
-  os?: Array<OperatingSystem | 'LOADING'>;
-  installMethod?: Array<string>;
-  platform?: Array<Platform | ''>;
-  semver?: Array<string>;
-  releases?: Array<NodeReleaseStatus>;
-};
-
-export type DownloadDropdownItem<T extends string> = {
-  label: IntlMessageKeys;
-  recommended?: boolean;
-  url?: string;
-  info?: IntlMessageKeys;
-  compatibility: DownloadCompatibility;
-} & Omit<SelectValue<T>, 'label'>;
-
 /**
  * Gets the next valid item when current item is disabled/excluded
  */

apps/site/util/url.ts

@@ -18,25 +18,18 @@ export const getNodeApiUrl = (version: string) => {
 };
 
 type DownloadOptions = {
+  /** The Node.js version string, must include the 'v' prefix (e.g., 'v20.12.2'). */
   version: string;
+  /** The target operating system. Defaults to 'LOADING'. */
   os?: OperatingSystem | 'LOADING';
+  /** The target platform/architecture (e.g., 'x64', 'arm64'). Defaults to 'x64'. */
   platform?: Platform;
+  /** The type of download artifact. Can be 'installer', 'binary', 'source', or 'shasum'. Defaults to 'installer'. */
   kind?: DownloadKind;
 };
 
 /**
- * Generates a Node.js download URL for the given options.
- *
- * @param options - The download options.
- * @param options.version - The Node.js version string, must include the 'v' prefix (e.g., 'v20.12.2').
- * @param options.os - The target operating system. Defaults to 'LOADING'.
- * @param options.platform - The target platform/architecture (e.g., 'x64', 'arm64'). Defaults to 'x64'.
- * @param options.kind - The type of download artifact. Can be 'installer', 'binary', 'source', or 'shasum'. Defaults to 'installer'.
- * @returns The fully qualified URL to the requested Node.js artifact.
- *
- * @example
- * getNodeDownloadUrl({ version: 'v20.12.2', os: 'MAC', platform: 'arm64', kind: 'binary' });
- * // => 'https://nodejs.org/dist/v20.12.2/node-v20.12.2-darwin-arm64.tar.gz'
+ * Generates a Node.js download URL for the given options
  */
 export const getNodeDownloadUrl = ({
   version,