Skip to content

Commit 7882a0c

Browse files
committed
Clarify release date values naming
1 parent 5bc3d5d commit 7882a0c

6 files changed

Lines changed: 13 additions & 25 deletions

File tree

apps/site/components/EOL/EOLReleaseTable/TableBody.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const EOLReleaseTableBody: FC<EOLReleaseTableBodyProps> = ({
3434
</td>
3535

3636
<td data-label="Date">
37-
<FormattedTime date={release.releaseDate} />
37+
<FormattedTime date={release.latestReleaseDate} />
3838
</td>
3939

4040
<td>

apps/site/components/Releases/PreviousReleasesTable/TableBody.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ const PreviousReleasesTableBody: FC<PreviousReleasesTableBodyProps> = ({
4343
<td
4444
data-label={t('components.downloadReleasesTable.firstReleased')}
4545
>
46-
<FormattedTime date={release.initialDate} />
46+
<FormattedTime date={release.initialReleaseDate} />
4747
</td>
4848

4949
<td data-label={t('components.downloadReleasesTable.lastUpdated')}>
50-
<FormattedTime date={release.releaseDate} />
50+
<FormattedTime date={release.latestReleaseDate} />
5151
</td>
5252

5353
<td data-label={t('components.downloadReleasesTable.status')}>

apps/site/components/Releases/ReleaseOverview/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ const ReleaseOverview: FC<ReleaseOverviewProps> = ({ release }) => {
2828
<div className={styles.container}>
2929
<ReleaseOverviewItem
3030
Icon={CalendarIcon}
31-
title={<FormattedTime date={release.initialDate} />}
31+
title={<FormattedTime date={release.initialReleaseDate} />}
3232
subtitle={t('components.releaseOverview.firstReleased')}
3333
/>
3434

3535
<ReleaseOverviewItem
3636
Icon={ClockIcon}
37-
title={<FormattedTime date={release.releaseDate} />}
37+
title={<FormattedTime date={release.latestReleaseDate} />}
3838
subtitle={t('components.releaseOverview.lastUpdated')}
3939
/>
4040

apps/site/next-data/generators/__tests__/releaseData.test.mjs

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,7 @@ describe('generateReleaseData', () => {
4343
},
4444
});
4545

46-
assert.equal(result.length, 1);
47-
assert.partialDeepStrictEqual(result[0], {
48-
major: 14,
49-
version: '14.0.0',
50-
versionWithPrefix: 'v14.0.0',
51-
codename: '',
52-
npm: '6.14.10',
53-
v8: '8.0.276.20',
54-
releaseDate: '2021-04-20',
55-
initialDate: '2021-04-20',
56-
modules: '83',
57-
status: 'EOL',
58-
});
46+
assert.equal(result[0]?.status, 'EOL');
5947
});
6048

6149
it('returns Current when release is not EOL and latest is not LTS', async t => {
@@ -142,7 +130,7 @@ describe('generateReleaseData', () => {
142130
assert.equal(result[0]?.status, 'Current');
143131
});
144132

145-
it('uses latest and earliest release dates for releaseDate and initialDate', async t => {
133+
it('uses latest and earliest release dates for latestReleaseDate and initialReleaseDate', async t => {
146134
const result = await runWithNodevuData(t, '2026-04-14', {
147135
26: {
148136
releases: {
@@ -174,7 +162,7 @@ describe('generateReleaseData', () => {
174162
},
175163
});
176164

177-
assert.equal(result[0]?.releaseDate, '2026-04-01');
178-
assert.equal(result[0]?.initialDate, '2025-10-21');
165+
assert.equal(result[0]?.latestReleaseDate, '2026-04-01');
166+
assert.equal(result[0]?.initialReleaseDate, '2025-10-21');
179167
});
180168
});

apps/site/next-data/generators/releaseData.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ const generateReleaseData = async () => {
5454
codename: major.support.codename || '',
5555
npm: latestVersion.dependencies.npm || '',
5656
v8: latestVersion.dependencies.v8,
57-
releaseDate: latestVersion.releaseDate,
58-
initialDate: initialVersion.releaseDate,
57+
latestReleaseDate: latestVersion.releaseDate,
58+
initialReleaseDate: initialVersion.releaseDate,
5959
modules: latestVersion.modules.version || '',
6060
minorVersions,
6161
};

apps/site/types/releases.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ export type NodeReleaseSource = {
66
codename?: string;
77
npm?: string;
88
v8: string;
9-
releaseDate: string;
10-
initialDate: string;
9+
latestReleaseDate: string;
10+
initialReleaseDate: string;
1111
modules?: string;
1212
};
1313

0 commit comments

Comments
 (0)