repl: use unicode chars for new lines

Author: puskin

lib/internal/repl/history.js

@@ -1,10 +1,16 @@
 'use strict';
 
 const {
+  ArrayPrototypeFilter,
   ArrayPrototypeJoin,
+  ArrayPrototypeMap,
+  ArrayPrototypeSlice,
   Boolean,
   FunctionPrototype,
+  RegExpPrototypeSymbolReplace,
   RegExpPrototypeSymbolSplit,
+  StringPrototypeReplace,
+  StringPrototypeSplit,
   StringPrototypeTrim,
 } = primordials;
 
@@ -23,6 +29,9 @@ const noop = FunctionPrototype;
 // XXX(chrisdickinson): The 15ms debounce value is somewhat arbitrary.
 // The debounce is to guard against code pasted into the REPL.
 const kDebounceHistoryMS = 15;
+const kCommandSeparator = '\0';
+const kLineSeparator = '\u2028'; // Unicode LINE SEPARATOR
+const kLineFeed = '\n';
 
 module.exports = setupHistory;
 
@@ -97,9 +106,27 @@ function setupHistory(repl, historyPath, ready) {
     }
 
     if (data) {
-      repl.history = RegExpPrototypeSymbolSplit(/\n+/, data, repl.historySize);
-    } else {
-      repl.history = [];
+      const splitOnCommandSeparator = StringPrototypeSplit(data, kCommandSeparator);
+      if (splitOnCommandSeparator.length > 1) {
+        repl.history = ArrayPrototypeFilter(
+          ArrayPrototypeMap(splitOnCommandSeparator,
+                            (cmd) => RegExpPrototypeSymbolReplace(
+                              /\r?\n+/g,
+                              StringPrototypeReplace(cmd, kLineSeparator, kLineFeed),
+                              kLineFeed,
+                            ),
+          ),
+          Boolean,
+        );
+      } else {
+        repl.history = RegExpPrototypeSymbolSplit(/\r?\n+/, data);
+      }
+
+      repl.history = ArrayPrototypeSlice(
+        repl.history,
+        0,
+        repl.historySize,
+      );
     }
 
     fs.open(historyPath, 'r+', onhandle);
@@ -141,7 +168,10 @@ function setupHistory(repl, historyPath, ready) {
       return;
     }
     writing = true;
-    const historyData = ArrayPrototypeJoin(repl.history, '\n');
+    const historyData = ArrayPrototypeJoin(
+      ArrayPrototypeMap(repl.history, (cmd) => StringPrototypeReplace(`${cmd}`, kLineFeed, kLineSeparator)),
+      kCommandSeparator,
+    );
     fs.write(repl._historyHandle, historyData, 0, 'utf8', onwritten);
   }