lib,crypto: validate HkdfParams info length early

Enforces a 1024-byte maximum on `HkdfParams.info` at the WebIDL layer
using refactored `validateMaxBufferLength`. Its error message is also
fixed.

Oversized `info` was already rejected via a different code path. It just
relocates the rejection earlier into the WebIDL conversion step so the
failure reproduces the OpenSSL's limitation early.

Signed-off-by: Filip Skokan <[email protected]>

Author: panva

lib/internal/crypto/util.js

@@ -526,10 +526,10 @@ const simpleAlgorithmDictionaries = {
   TurboShakeParams: {},
 };
 
-function validateMaxBufferLength(data, name) {
-  if (data.byteLength > kMaxBufferLength) {
+function validateMaxBufferLength(data, name, max = kMaxBufferLength) {
+  if (data.byteLength > max) {
     throw lazyDOMException(
-      `${name} must be less than ${kMaxBufferLength + 1} bits`,
+      `${name} must be at most ${max} bytes`,
       'OperationError');
   }
 }

lib/internal/crypto/webidl.js

@@ -567,6 +567,7 @@ converters.HkdfParams = createDictionaryConverter(
     {
       key: 'info',
       converter: converters.BufferSource,
+      validator: (V, dict) => validateMaxBufferLength(V, 'algorithm.info', 1024),
       required: true,
     },
   ]);

test/parallel/test-webcrypto-derivebits-hkdf.js

@@ -628,16 +628,27 @@ async function testWrongKeyType(
 })().then(common.mustCall());
 
 // https://github.com/w3c/webcrypto/pull/380
-{
-  crypto.subtle.importKey('raw', new Uint8Array(0), 'HKDF', false, ['deriveBits']).then((key) => {
-    return crypto.subtle.deriveBits({
-      name: 'HKDF',
-      hash: { name: 'SHA-256' },
-      info: new Uint8Array(0),
-      salt: new Uint8Array(0),
-    }, key, 0);
-  }).then((bits) => {
-    assert.deepStrictEqual(bits, new ArrayBuffer(0));
-  })
-  .then(common.mustCall());
-}
+(async function() {
+  const key = await crypto.subtle.importKey('raw', new Uint8Array(0), 'HKDF', false, ['deriveBits']);
+  const bits = await crypto.subtle.deriveBits({
+    name: 'HKDF',
+    hash: { name: 'SHA-256' },
+    info: new Uint8Array(0),
+    salt: new Uint8Array(0),
+  }, key, 0);
+  assert.deepStrictEqual(bits, new ArrayBuffer(0));
+})().then(common.mustCall());
+
+// OpenSSL limits info to 1024 bytes
+(async function() {
+  const key = await crypto.subtle.importKey('raw', new Uint8Array(0), 'HKDF', false, ['deriveBits']);
+  await assert.rejects(crypto.subtle.deriveBits({
+    name: 'HKDF',
+    hash: { name: 'SHA-256' },
+    info: new Uint8Array(1025),
+    salt: new Uint8Array(0),
+  }, key, 0), {
+    name: 'OperationError',
+    message: 'algorithm.info must be at most 1024 bytes',
+  });
+})().then(common.mustCall());