fix: windows dns server resolution

greguintow · greguintow · commit f1d48a578dee · 2026-04-24T17:34:47.000-03:00
diff --git a/deps/cares/src/lib/ares_sysconfig_win.c b/deps/cares/src/lib/ares_sysconfig_win.c
@@ -638,11 +638,9 @@ ares_status_t ares_init_sysconfig_windows(const ares_channel_t *channel,
   if (get_SuffixList_Windows(&line)) {
     sysconfig->domains = ares_strsplit(line, ", ", &sysconfig->ndomains);
     ares_free(line);
+    /* Keep discovered DNS servers even if suffix parsing fails. */
     if (sysconfig->domains == NULL) {
-      status = ARES_EFILE;
-    }
-    if (status != ARES_SUCCESS) {
-      goto done;
+      sysconfig->ndomains = 0;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -638,11 +638,9 @@ ares_status_t ares_init_sysconfig_windows(const ares_channel_t *channel,`
`638`	`638`	`if (get_SuffixList_Windows(&line)) {`
`639`	`639`	`sysconfig->domains = ares_strsplit(line, ", ", &sysconfig->ndomains);`
`640`	`640`	`ares_free(line);`
	`641`	`+ /* Keep discovered DNS servers even if suffix parsing fails. */`
`641`	`642`	`if (sysconfig->domains == NULL) {`
`642`		`- status = ARES_EFILE;`
`643`		`- }`
`644`		`- if (status != ARES_SUCCESS) {`
`645`		`- goto done;`
	`643`	`+ sysconfig->ndomains = 0;`
`646`	`644`	`}`
`647`	`645`	`}`
`648`	`646`