Skip to content

Commit e526856

Browse files
committed
fixup! benchmark: ensure integer division in http headers benchmark
1 parent 668997f commit e526856

1 file changed

Lines changed: 17 additions & 16 deletions

File tree

doc/contributing/writing-and-running-benchmarks.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -735,14 +735,6 @@ Supported options keys are:
735735
* `benchmarker` - benchmarker to use, defaults to the first available http
736736
benchmarker
737737

738-
[autocannon]: https://github.com/mcollina/autocannon
739-
[benchmark-ci]: https://github.com/nodejs/benchmarking/blob/HEAD/docs/core_benchmarks.md
740-
[git-for-windows]: https://git-scm.com/download/win
741-
[nghttp2.org]: https://nghttp2.org
742-
[node-benchmark-compare]: https://github.com/targos/node-benchmark-compare
743-
[t-test]: https://en.wikipedia.org/wiki/Student%27s_t-test#Equal_or_unequal_sample_sizes%2C_unequal_variances_%28sX1_%3E_2sX2_or_sX2_%3E_2sX1%29
744-
[wrk]: https://github.com/wg/wrk
745-
746738
### Creating Benchmark Tests
747739

748740
It is recommended to create a new test file when a new benchmark is introduced
@@ -777,24 +769,33 @@ only a single configuration per benchmark executes.
777769
While this dramatically reduces execution time, it provides limited coverage
778770
and cannot guarantee that all configurations function properly.
779771

780-
This PR introduces the usage of a new environment variable `NODE_RUN_ALL_BENCH_TESTS`, which can be set to run all benchmark configurations in tests to cover more scenarios where benchmarks might fail.
772+
This PR introduces the usage of a new environment variable `NODE_RUN_ALL_BENCH_TESTS`,
773+
which can be set to run all benchmark configurations in tests to cover more scenarios where benchmarks might fail.
781774
This PR also documents how to write benchmark tests and provides more details about the environment variables:
782775

783-
* NODE_RUN_ALL_BENCH_TESTS
784-
* NODEJS_BENCHMARK_ZERO_ALLOWED
776+
* NODE\_RUN\_ALL\_BENCH\_TESTS
777+
* NODEJS\_BENCHMARK\_ZERO\_ALLOWED
785778

786779
Benchmark tests were added for the following groups:
787780

788-
* abort_controller
781+
* abort\_controller
789782
* error
790783
* https
791-
* perf_hooks
784+
* perf\_hooks
792785
* permission
793786
* sqlite
794-
* test_runner
787+
* test\_runner
795788
* websocket
796789

797790
Additionally, some inconsistent test files were renamed:
798791

799-
test/benchmark/test-benchmark-async-hooks.js → test/benchmark/test-benchmark-async_hooks.js
800-
test/benchmark/test-benchmark-child-process.js → test/benchmark/test-benchmark-child_process.js
792+
test/benchmark/test-benchmark-async-hooks.js → test/benchmark/test-benchmark-async\_hooks.js
793+
test/benchmark/test-benchmark-child-process.js → test/benchmark/test-benchmark-child\_process.js
794+
795+
[autocannon]: https://github.com/mcollina/autocannon
796+
[benchmark-ci]: https://github.com/nodejs/benchmarking/blob/HEAD/docs/core_benchmarks.md
797+
[git-for-windows]: https://git-scm.com/download/win
798+
[nghttp2.org]: https://nghttp2.org
799+
[node-benchmark-compare]: https://github.com/targos/node-benchmark-compare
800+
[t-test]: https://en.wikipedia.org/wiki/Student%27s_t-test#Equal_or_unequal_sample_sizes%2C_unequal_variances_%28sX1_%3E_2sX2_or_sX2_%3E_2sX1%29
801+
[wrk]: https://github.com/wg/wrk

0 commit comments

Comments
 (0)