fixup! src: run schema validation before option parsing

Author: mertcanaltin

src/node_config_file.cc

@@ -222,9 +222,31 @@ ParseResult ConfigReader::ParseConfig(const std::string_view& config_path) {
     return ParseResult::FileError;
   }
 
-  // Validate against JSON Schema before parsing options.
-  // ata works on the raw string independently of simdjson,
-  // so no re-parse is needed.
+  // Parse the configuration file
+  simdjson::ondemand::parser json_parser;
+  simdjson::ondemand::document document;
+  if (json_parser.iterate(file_content).get(document)) {
+    FPrintF(stderr, "Can't parse %s\n", config_path.data());
+    return ParseResult::InvalidContent;
+  }
+
+  // Validate config is an object
+  simdjson::ondemand::object main_object;
+  auto root_error = document.get_object().get(main_object);
+  if (root_error) {
+    if (root_error == simdjson::error_code::INCORRECT_TYPE) {
+      FPrintF(stderr,
+              "Root value unexpected not an object for %s\n\n",
+              config_path.data());
+    } else {
+      FPrintF(stderr, "Can't parse %s\n", config_path.data());
+    }
+    return ParseResult::InvalidContent;
+  }
+
+  // Validate against JSON Schema after basic parsing succeeds.
+  // This catches type errors in properties before the option
+  // parsing loop, which would otherwise produce less clear messages.
   {
     auto schema = ata::compile(kNodeConfigSchema);
     if (schema) {
@@ -249,28 +271,6 @@ ParseResult ConfigReader::ParseConfig(const std::string_view& config_path) {
     }
   }
 
-  // Parse the configuration file
-  simdjson::ondemand::parser json_parser;
-  simdjson::ondemand::document document;
-  if (json_parser.iterate(file_content).get(document)) {
-    FPrintF(stderr, "Can't parse %s\n", config_path.data());
-    return ParseResult::InvalidContent;
-  }
-
-  // Validate config is an object
-  simdjson::ondemand::object main_object;
-  auto root_error = document.get_object().get(main_object);
-  if (root_error) {
-    if (root_error == simdjson::error_code::INCORRECT_TYPE) {
-      FPrintF(stderr,
-              "Root value unexpected not an object for %s\n\n",
-              config_path.data());
-    } else {
-      FPrintF(stderr, "Can't parse %s\n", config_path.data());
-    }
-    return ParseResult::InvalidContent;
-  }
-
   // Get all available namespaces for validation
   std::vector<std::string> available_namespaces =
       options_parser::MapAvailableNamespaces();