lib: use js-only implementation of isDataView()

Author: Renegade334

benchmark/util/type-check.js

@@ -23,6 +23,11 @@ const args = {
     'false-primitive': true,
     'false-object': int32Array,
   },
+  DataView: {
+    'true': dataView,
+    'false-primitive': true,
+    'false-object': uint8Array,
+  },
 };
 
 const bench = common.createBenchmark(main, {

lib/internal/util/types.js

@@ -6,6 +6,10 @@ const {
   TypedArrayPrototypeGetSymbolToStringTag,
 } = primordials;
 
+function isDataView(value) {
+  return ArrayBufferIsView(value) && TypedArrayPrototypeGetSymbolToStringTag(value) === undefined;
+}
+
 function isTypedArray(value) {
   return TypedArrayPrototypeGetSymbolToStringTag(value) !== undefined;
 }
@@ -61,6 +65,7 @@ function isBigUint64Array(value) {
 module.exports = {
   ...internalBinding('types'),
   isArrayBufferView: ArrayBufferIsView,
+  isDataView,
   isTypedArray,
   isUint8Array,
   isUint8ClampedArray,

src/node_types.cc

@@ -19,7 +19,6 @@ namespace {
   V(AsyncFunction)                                                             \
   V(BigIntObject)                                                              \
   V(BooleanObject)                                                             \
-  V(DataView)                                                                  \
   V(Date)                                                                      \
   V(External)                                                                  \
   V(GeneratorFunction)                                                         \