test_runner: enhance expectFailure with validation support

Enhance `expectFailure` option to accep

- Add `message` property for custom TAP directives.
- Add `with` property for error validation using `assert.throws`.

Tests added in `test/parallel/test-runner-xfail.js`.

Author: Han5991

lib/internal/test_runner/test.js

@@ -56,8 +56,8 @@ const {
   once: runOnce,
   setOwnProperty,
 } = require('internal/util');
-const { isDeepStrictEqual } = require('internal/util/comparisons');
-const { isPromise, isRegExp } = require('internal/util/types');
+const assert = require('assert');
+const { isPromise } = require('internal/util/types');
 const {
   validateAbortSignal,
   validateFunction,
@@ -959,29 +959,15 @@ class Test extends AsyncResource {
       if (typeof this.expectFailure === 'object' &&
           this.expectFailure.with !== undefined) {
         const { with: validation } = this.expectFailure;
-        let match = false;
-
-        if (isRegExp(validation)) {
-          match = RegExpPrototypeExec(validation, err.message) !== null;
-        } else if (typeof validation === 'object' && validation !== null) {
-          match = true;
-          for (const prop in validation) {
-            if (!isDeepStrictEqual(err[prop], validation[prop])) {
-              match = false;
-              break;
-            }
-          }
-        } else if (validation === err) {
-          match = true;
-        }
-
-        if (!match) {
+        try {
+          assert.throws(() => { throw err; }, validation);
+        } catch (e) {
           this.passed = false;
           this.error = new ERR_TEST_FAILURE(
             'The test failed, but the error did not match the expected validation',
             kTestCodeFailure,
           );
-          this.error.cause = err;
+          this.error.cause = e;
           return;
         }
       }

test/parallel/test-runner-xfail.js

@@ -21,6 +21,10 @@ if (process.env.CHILD_PROCESS === 'true') {
     assert.fail('boom');
   });
 
+  test('fail with validation class', { expectFailure: { with: assert.AssertionError } }, () => {
+    assert.fail('boom');
+  });
+
   test('fail with validation error (wrong error)', { expectFailure: { with: /bang/ } }, () => {
     assert.fail('boom'); // Should result in real failure because error doesn't match
   });