Skip to content

Commit d40be95

Browse files
joyeecheungtargos
authored andcommitted
deps: V8: cherry-pick d83f479604c8
Original commit message: Fix compilation for older version of libstdc++ On older versions of libstdc++, cmath didn't expose std::powl. Use std::pow instead. Co-Authored-By: René <[email protected]> Refs: https://gcc.gnu.org/pipermail/libstdc++/2023-February/055493.html Refs: #61898 Change-Id: I4587e14525cae68a05eda03c36b0af40759d9b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7666244 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Jakob Linke <[email protected]> Cr-Commit-Position: refs/heads/main@{#105884} Refs: v8/v8@d83f479 PR-URL: #61898 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
1 parent 38d98c3 commit d40be95

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
# Reset this number to 0 on major V8 upgrades.
4242
# Increment by one for each non-official patch applied to deps/v8.
43-
'v8_embedder_string': '-node.9',
43+
'v8_embedder_string': '-node.10',
4444

4545
##### V8 defaults for Node.js #####
4646

deps/v8/src/objects/js-duration-format.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ void OutputFractional(const char* type, int64_t integer, int32_t powerOfTen,
807807
// Pass in the value as int64_t and ask ICU to scale down.
808808
nfOpts = nfOpts.scale(icu::number::Scale::powerOfTen(-powerOfTen));
809809

810-
int64_t factor = static_cast<int64_t>(std::powl(10, powerOfTen));
810+
int64_t factor = static_cast<int64_t>(std::pow(10.0L, powerOfTen));
811811
int64_t bound = std::numeric_limits<int64_t>::max() / factor - 1;
812812
UErrorCode status = U_ZERO_ERROR;
813813
// Use faster ICU API formatInt if the value fit the precision int64_t,

0 commit comments

Comments
 (0)