Skip to content

Commit ce416a2

Browse files
authored
Refactor peer close handling in PipeWrap
1 parent dc21154 commit ce416a2

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/pipe_wrap.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -233,20 +233,21 @@ void PipeWrap::WatchPeerClose(const FunctionCallbackInfo<Value>& args) {
233233
if (!enable) {
234234
if (!wrap->peer_close_watching_) {
235235
wrap->peer_close_cb_.Reset();
236-
return args.GetReturnValue().Set(0);
236+
return;
237237
}
238238

239239
wrap->peer_close_watching_ = false;
240240
wrap->peer_close_cb_.Reset();
241-
return args.GetReturnValue().Set(uv_read_stop(wrap->stream()));
241+
uv_read_stop(wrap->stream());
242+
return;
242243
}
243244

244245
if (!wrap->IsAlive()) {
245-
return args.GetReturnValue().Set(UV_EBADF);
246+
return;
246247
}
247248

248249
if (wrap->peer_close_watching_) {
249-
return args.GetReturnValue().Set(0);
250+
return;
250251
}
251252

252253
CHECK_GT(args.Length(), 1);
@@ -266,7 +267,6 @@ void PipeWrap::WatchPeerClose(const FunctionCallbackInfo<Value>& args) {
266267
wrap->peer_close_watching_ = false;
267268
wrap->peer_close_cb_.Reset();
268269
}
269-
args.GetReturnValue().Set(err);
270270
}
271271

272272
void PipeWrap::PeerCloseAlloc(uv_handle_t* handle,

0 commit comments

Comments
 (0)