fixup! src,crypto: add NativeCryptoKey

Author: panva

src/crypto/crypto_keys.cc

@@ -1885,7 +1885,7 @@ void NativeCryptoKey::CreateCryptoKeyClass(
 }
 
 // Returns all of the key's internal slot values as a single Array:
-// [type, extractable, algorithm, usages, handle]. JS-side helpers
+// [type enum, extractable, algorithm, usages, handle]. JS-side helpers
 // call this once per key to prime a per-instance cache, so subsequent
 // reads don't need to cross into C++ at all.
 void NativeCryptoKey::GetSlots(const FunctionCallbackInfo<Value>& args) {
@@ -1899,21 +1899,6 @@ void NativeCryptoKey::GetSlots(const FunctionCallbackInfo<Value>& args) {
   Local<Object> obj = args[0].As<Object>();
   NativeCryptoKey* native = Unwrap<NativeCryptoKey>(obj);
 
-  const char* type_str;
-  switch (native->handle_data_.GetKeyType()) {
-    case kKeyTypeSecret:
-      type_str = "secret";
-      break;
-    case kKeyTypePublic:
-      type_str = "public";
-      break;
-    case kKeyTypePrivate:
-      type_str = "private";
-      break;
-    default:
-      UNREACHABLE();
-  }
-
   Local<Object> handle;
   if (!KeyObjectHandle::Create(env, native->handle_data_).ToLocal(&handle)) {
     return;
@@ -1924,7 +1909,7 @@ void NativeCryptoKey::GetSlots(const FunctionCallbackInfo<Value>& args) {
   CHECK(algorithm->IsObject());
   CHECK(usages->IsArray());
   Local<Value> slots[] = {
-      OneByteString(isolate, type_str),
+      Uint32::NewFromUnsigned(isolate, native->handle_data_.GetKeyType()),
       v8::Boolean::New(isolate, native->extractable_),
       algorithm,
       usages,

src/env_properties.h

@@ -478,10 +478,10 @@
   V(async_hooks_init_function, v8::Function)                                   \
   V(async_hooks_promise_resolve_function, v8::Function)                        \
   V(buffer_prototype_object, v8::Object)                                       \
+  V(crypto_internal_cryptokey_constructor, v8::Function)                       \
   V(crypto_key_object_private_constructor, v8::Function)                       \
   V(crypto_key_object_public_constructor, v8::Function)                        \
   V(crypto_key_object_secret_constructor, v8::Function)                        \
-  V(crypto_internal_cryptokey_constructor, v8::Function)                       \
   V(enhance_fatal_stack_after_inspector, v8::Function)                         \
   V(enhance_fatal_stack_before_inspector, v8::Function)                        \
   V(get_source_map_error_source, v8::Function)                                 \