deps: patch V8 to fix Windows build

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

Author: StefanStojanovic

common.gypi

@@ -40,7 +40,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.6',
+    'v8_embedder_string': '-node.7',
 
     ##### V8 defaults for Node.js #####
 

deps/v8/include/v8-internal.h

@@ -479,7 +479,11 @@ struct TagRange {
   constexpr TagRange(Tag first, Tag last) : first(first), last(last) {
 #ifdef V8_ENABLE_CHECKS
     // This would typically be a DCHECK, but that's not available here.
+#if V8_HAS_BUILTIN_UNREACHABLE
     if (first > last) __builtin_unreachable();  // Invalid tag range.
+#elif defined(_MSC_VER)
+    if (first > last) __assume(0);  // Invalid tag range.
+#endif
 #endif
   }
 

deps/v8/src/flags/flags.cc

@@ -307,8 +307,13 @@ constexpr size_t kNumFlags = arraysize(flags);
 
 base::Vector<Flag> Flags() { return base::ArrayVector(flags); }
 
+#if V8_CC_MSVC && defined(_DEBUG)
+std::array<int, kNumFlags> GetSortedFlagIndices() {
+  const char* kFlagNames[] = {
+#else
 consteval std::array<int, kNumFlags> GetSortedFlagIndices() {
   constexpr const char* kFlagNames[] = {
+#endif
 #define FLAG_MODE_APPLY_NAME(nam) #nam,
 #define FLAG_ALIAS(ftype, ctype, alias, nam) #alias,
 #include "src/flags/flag-definitions.h"  // NOLINT(build/include)
@@ -340,7 +345,11 @@ struct FlagNameGreater {
 class FlagMapByName {
  public:
   FlagMapByName() {
+#if V8_CC_MSVC && defined(_DEBUG)
+    const std::array<int, kNumFlags> sorted_indices =
+#else
     constexpr std::array<int, kNumFlags> sorted_indices =
+#endif
         GetSortedFlagIndices();
     for (size_t i = 0; i < kNumFlags; ++i) {
       flags_[i] = &flags[sorted_indices[i]];

deps/v8/src/objects/backing-store.cc

@@ -322,7 +322,7 @@ std::unique_ptr<BackingStore> BackingStore::TryAllocateAndPartiallyCommitMemory(
   // For accounting purposes, whether a GC was necessary.
   bool did_retry = false;
 
-  auto gc_retry = [&](const std::function<bool()>& fn) {
+  auto gc_retry = [&](const auto& fn) {
     if (fn()) return true;
     // Collect garbage and retry.
     did_retry = true;