src: -Wunreachable-code-break in node_config_file.cc

codebytere · codebytere · commit b5b4d51e6ced · 2025-06-30T11:51:02.000+02:00
../../third_party/electron_node/src/node_config_file.cc:142:11: error: 'break' will never be executed [-Werror,-Wunreachable-code-break]
  142 |           break;
      |           ^~~~~
1 error generated.
diff --git a/src/node_config_file.cc b/src/node_config_file.cc
@@ -131,7 +131,6 @@ ParseResult ConfigReader::ProcessOptionValue(
               "No-op flag %s is currently not supported\n",
               option_name.c_str());
       return ParseResult::InvalidContent;
-      break;
     }
     case options_parser::OptionType::kV8Option: {
       FPrintF(stderr,

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,6 @@ ParseResult ConfigReader::ProcessOptionValue(`
`131`	`131`	`"No-op flag %s is currently not supported\n",`
`132`	`132`	`option_name.c_str());`
`133`	`133`	`return ParseResult::InvalidContent;`
`134`		`- break;`
`135`	`134`	`}`
`136`	`135`	`case options_parser::OptionType::kV8Option: {`
`137`	`136`	`FPrintF(stderr,`