fixup! lib: refactor internal webidl converters

Author: panva

benchmark/misc/webidl-convert-to-int.js

@@ -21,6 +21,21 @@ const bench = common.createBenchmark(main, {
   n: [1e6],
 }, { flags: ['--expose-internals'] });
 
+function getConverter(converter) {
+  switch (converter) {
+    case 'octet':
+      return { bitLength: 8 };
+    case 'unsigned short':
+      return { bitLength: 16 };
+    case 'unsigned long':
+      return { bitLength: 32 };
+    case 'long long':
+      return { bitLength: 64, signedness: 'signed' };
+    default:
+      throw new Error(`Unsupported converter: ${converter}`);
+  }
+}
+
 function getInput(input) {
   switch (input) {
     case 'integer':
@@ -45,18 +60,18 @@ function getInput(input) {
 }
 
 function main({ n, converter, input }) {
-  const { converters } = require('internal/webidl');
-  const convert = converters[converter];
+  const { convertToInt } = require('internal/webidl');
+  const { bitLength, signedness } = getConverter(converter);
   const { value, options } = getInput(input);
 
   let noDead;
   bench.start();
   if (options === undefined) {
     for (let i = 0; i < n; i++)
-      noDead = convert(value);
+      noDead = convertToInt(value, bitLength, signedness);
   } else {
     for (let i = 0; i < n; i++)
-      noDead = convert(value, options);
+      noDead = convertToInt(value, bitLength, signedness, options);
   }
   bench.end(n);