fixup! src,crypto: add NativeCryptoKey

Signed-off-by: Filip Skokan <[email protected]>

Author: panva

src/crypto/crypto_keys.cc

@@ -1793,18 +1793,13 @@ void NativeCryptoKey::Initialize(Environment* env, Local<Object> target) {
             target,
             "createCryptoKeyClass",
             NativeCryptoKey::CreateCryptoKeyClass);
-  SetMethod(env->context(),
-            target,
-            "getCryptoKeyHandle",
-            NativeCryptoKey::GetKeyHandle);
   SetMethod(
       env->context(), target, "getCryptoKeySlots", NativeCryptoKey::GetSlots);
 }
 
 void NativeCryptoKey::RegisterExternalReferences(
     ExternalReferenceRegistry* registry) {
   registry->Register(NativeCryptoKey::CreateCryptoKeyClass);
-  registry->Register(NativeCryptoKey::GetKeyHandle);
   registry->Register(NativeCryptoKey::GetSlots);
   registry->Register(NativeCryptoKey::New);
 }
@@ -1900,18 +1895,6 @@ void NativeCryptoKey::CreateCryptoKeyClass(
   args.GetReturnValue().Set(ret);
 }
 
-void NativeCryptoKey::GetKeyHandle(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
-  CHECK_EQ(args.Length(), 1);
-  CHECK(HasInstance(args[0]));
-  NativeCryptoKey* native = Unwrap<NativeCryptoKey>(args[0].As<Object>());
-  Local<Object> handle;
-  if (!KeyObjectHandle::Create(env, native->handle_data_).ToLocal(&handle)) {
-    return;
-  }
-  args.GetReturnValue().Set(handle);
-}
-
 // Returns all of the key's internal slot values as a single Array:
 // [type, extractable, algorithm, usages, handle]. JS-side helpers
 // call this once per key to prime a per-instance cache, so subsequent

src/crypto/crypto_keys.h

@@ -258,10 +258,9 @@ class NativeCryptoKey : public BaseObject {
 
   // True if `value` is a real NativeCryptoKey instance. Checks the
   // kClassTagField internal field.
-  // Used by `GetSlots` / `GetKeyHandle` to validate their receiver.
+  // Used by `GetSlots` to validate its receiver.
   static bool HasInstance(v8::Local<v8::Value> value);
 
-  static void GetKeyHandle(const v8::FunctionCallbackInfo<v8::Value>& args);
   // Returns [type, extractable, algorithm, usages, handle] in one call
   // so JS can prime a per-instance cache on first access.
   static void GetSlots(const v8::FunctionCallbackInfo<v8::Value>& args);