resolve feedback

Author: thisalihassan

lib/buffer.js

@@ -1267,13 +1267,15 @@ function swap(b, n, m) {
 }
 
 Buffer.prototype.swap16 = function swap16() {
-  // For Buffer.length < 128, it's generally faster to
+  // For Buffer.length <= 32, it's generally faster to
   // do the swap in javascript. For larger buffers,
   // dropping down to the native code is faster.
+  if (!isUint8Array(this))
+    throw new ERR_INVALID_ARG_TYPE('this', ['Buffer', 'Uint8Array'], this);
   const len = this.length;
   if (len % 2 !== 0)
     throw new ERR_INVALID_BUFFER_SIZE('16-bits');
-  if (len < 128) {
+  if (len <= 32) {
     for (let i = 0; i < len; i += 2)
       swap(this, i, i + 1);
     return this;
@@ -1283,13 +1285,15 @@ Buffer.prototype.swap16 = function swap16() {
 };
 
 Buffer.prototype.swap32 = function swap32() {
-  // For Buffer.length < 192, it's generally faster to
+  // For Buffer.length <= 32, it's generally faster to
   // do the swap in javascript. For larger buffers,
   // dropping down to the native code is faster.
+  if (!isUint8Array(this))
+    throw new ERR_INVALID_ARG_TYPE('this', ['Buffer', 'Uint8Array'], this);
   const len = this.length;
   if (len % 4 !== 0)
     throw new ERR_INVALID_BUFFER_SIZE('32-bits');
-  if (len < 192) {
+  if (len <= 32) {
     for (let i = 0; i < len; i += 4) {
       swap(this, i, i + 3);
       swap(this, i + 1, i + 2);
@@ -1301,13 +1305,15 @@ Buffer.prototype.swap32 = function swap32() {
 };
 
 Buffer.prototype.swap64 = function swap64() {
-  // For Buffer.length < 192, it's generally faster to
+  // For Buffer.length < 48, it's generally faster to
   // do the swap in javascript. For larger buffers,
   // dropping down to the native code is faster.
+  if (!isUint8Array(this))
+    throw new ERR_INVALID_ARG_TYPE('this', ['Buffer', 'Uint8Array'], this);
   const len = this.length;
   if (len % 8 !== 0)
     throw new ERR_INVALID_BUFFER_SIZE('64-bits');
-  if (len < 192) {
+  if (len < 48) {
     for (let i = 0; i < len; i += 8) {
       swap(this, i, i + 7);
       swap(this, i + 1, i + 6);

src/node_buffer.cc

@@ -1200,6 +1200,7 @@ int32_t FastIndexOfNumber(Local<Value>,
 static CFunction fast_index_of_number(CFunction::Make(FastIndexOfNumber));
 
 void Swap16(const FunctionCallbackInfo<Value>& args) {
+  DCHECK(args[0]->IsArrayBufferView());
   SPREAD_BUFFER_ARG(args[0], ts_obj);
   CHECK(nbytes::SwapBytes16(ts_obj_data, ts_obj_length));
 }
@@ -1217,6 +1218,7 @@ void FastSwap16(Local<Value> receiver,
 static CFunction fast_swap16(CFunction::Make(FastSwap16));
 
 void Swap32(const FunctionCallbackInfo<Value>& args) {
+  DCHECK(args[0]->IsArrayBufferView());
   SPREAD_BUFFER_ARG(args[0], ts_obj);
   CHECK(nbytes::SwapBytes32(ts_obj_data, ts_obj_length));
 }
@@ -1234,6 +1236,7 @@ void FastSwap32(Local<Value> receiver,
 static CFunction fast_swap32(CFunction::Make(FastSwap32));
 
 void Swap64(const FunctionCallbackInfo<Value>& args) {
+  DCHECK(args[0]->IsArrayBufferView());
   SPREAD_BUFFER_ARG(args[0], ts_obj);
   CHECK(nbytes::SwapBytes64(ts_obj_data, ts_obj_length));
 }