http: increase keepAliveTimeout default to 65 seconds

Co-authored-by: Prashant Bansal <[email protected]>
Signed-off-by: Tim Perry <[email protected]>
PR-URL: #62782
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

Author: pimterry

doc/api/http.md

@@ -1999,9 +1999,13 @@ value only affects new connections to the server, not any existing connections.
 
 <!-- YAML
 added: v8.0.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/62782
+    description: the default value for `http.Server.keepAliveTimeout` is changed from 5 to 65 seconds.
 -->
 
-* Type: {number} Timeout in milliseconds. **Default:** `5000` (5 seconds).
+* Type: {number} Timeout in milliseconds. **Default:** `65000` (65 seconds).
 
 The number of milliseconds of inactivity a server needs to wait for additional
 incoming data, after it has finished writing the last response, before a socket

lib/_http_server.js

@@ -499,7 +499,7 @@ function storeHTTPOptions(options) {
     validateInteger(keepAliveTimeout, 'keepAliveTimeout', 0);
     this.keepAliveTimeout = keepAliveTimeout;
   } else {
-    this.keepAliveTimeout = 5_000; // 5 seconds;
+    this.keepAliveTimeout = 65_000; // 65 seconds;
   }
 
   const keepAliveTimeoutBuffer = options.keepAliveTimeoutBuffer;

test/parallel/test-http-keep-alive-max-requests.js

@@ -10,11 +10,11 @@ const bodySent = 'This is my request';
 function assertResponse(headers, body, expectClosed) {
   if (expectClosed) {
     assert.match(headers, /Connection: close\r\n/m);
-    assert.strictEqual(headers.search(/Keep-Alive: timeout=5\r\n/m), -1);
+    assert.strictEqual(headers.search(/Keep-Alive: timeout=65\r\n/m), -1);
     assert.match(body, /Hello World!/m);
   } else {
     assert.match(headers, /Connection: keep-alive\r\n/m);
-    assert.match(headers, /Keep-Alive: timeout=5, max=3\r\n/m);
+    assert.match(headers, /Keep-Alive: timeout=65, max=3\r\n/m);
     assert.match(body, /Hello World!/m);
   }
 }

test/parallel/test-http-keep-alive-pipeline-max-requests.js

@@ -10,11 +10,11 @@ const bodySent = 'This is my request';
 function assertResponse(headers, body, expectClosed) {
   if (expectClosed) {
     assert.match(headers, /Connection: close\r\n/m);
-    assert.strictEqual(headers.search(/Keep-Alive: timeout=5, max=3\r\n/m), -1);
+    assert.strictEqual(headers.search(/Keep-Alive: timeout=65, max=3\r\n/m), -1);
     assert.match(body, /Hello World!/m);
   } else {
     assert.match(headers, /Connection: keep-alive\r\n/m);
-    assert.match(headers, /Keep-Alive: timeout=5, max=3\r\n/m);
+    assert.match(headers, /Keep-Alive: timeout=65, max=3\r\n/m);
     assert.match(body, /Hello World!/m);
   }
 }
@@ -76,7 +76,7 @@ server.listen(0, common.mustCall((res) => {
 
       assert.match(responseParts[6], /HTTP\/1\.1 503 Service Unavailable/m);
       assert.match(responseParts[6], /Connection: close\r\n/m);
-      assert.strictEqual(responseParts[6].search(/Keep-Alive: timeout=5\r\n/m), -1);
+      assert.strictEqual(responseParts[6].search(/Keep-Alive: timeout=65\r\n/m), -1);
       assert.strictEqual(responseParts[7].search(/Hello World!/m), -1);
 
       socket.end();

test/parallel/test-http-server-keep-alive-defaults.js

@@ -9,7 +9,7 @@ const bodySent = 'This is my request';
 
 function assertResponse(headers, body, expectClosed) {
   assert.match(headers, /Connection: keep-alive\r\n/m);
-  assert.match(headers, /Keep-Alive: timeout=5\r\n/m);
+  assert.match(headers, /Keep-Alive: timeout=65\r\n/m);
   assert.match(body, /Hello World!/m);
 }
 

test/parallel/test-http-server-keep-alive-max-requests-null.js

@@ -9,7 +9,7 @@ const bodySent = 'This is my request';
 
 function assertResponse(headers, body, expectClosed) {
   assert.match(headers, /Connection: keep-alive\r\n/m);
-  assert.match(headers, /Keep-Alive: timeout=5\r\n/m);
+  assert.match(headers, /Keep-Alive: timeout=65\r\n/m);
   assert.match(body, /Hello World!/m);
 }