Merge branch 'main' into feat/allow-env

Author: nabeel378

.github/CODEOWNERS

@@ -83,6 +83,15 @@
 /src/node_http2* @nodejs/http2 @nodejs/net
 /src/node_mem* @nodejs/http2
 
+# quic
+
+/deps/ngtcp2/* @nodejs/quic
+/doc/api/quic.md @nodejs/quic
+/lib/quic.js @nodejs/quic
+/lib/internal/quic/* @nodejs/quic
+/src/quic/* @nodejs/quic
+/test/parallel/test-quic-* @nodejs/quic
+
 # modules, including loaders
 
 /doc/api/esm.md @nodejs/loaders

.github/actions/undici-wpt-current/action.yml

@@ -0,0 +1,56 @@
+name: Run undici WPT (current)
+description: Runs undici WPT tests for undici >= 7 and merges results into the Node.js WPT report
+
+inputs:
+  undici-version:
+    required: true
+    description: undici version tag to checkout
+  wpt-report:
+    required: true
+    description: Path to the Node.js WPT report to merge into
+
+runs:
+  using: composite
+  steps:
+    - name: Checkout undici
+      uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+      with:
+        repository: nodejs/undici
+        persist-credentials: false
+        path: undici
+        clean: false
+        ref: ${{ inputs.undici-version }}
+    - name: Prepare WPT checkout
+      shell: bash
+      run: |
+        rm -rf undici/test/web-platform-tests/wpt
+        mv test/fixtures/wpt undici/test/web-platform-tests/wpt
+    - name: Configure hosts
+      shell: bash
+      working-directory: undici/test/web-platform-tests/wpt
+      run: python3 wpt make-hosts-file | sudo tee -a /etc/hosts
+    - name: Install dependencies
+      shell: bash
+      working-directory: undici
+      run: npm install
+    - name: Run WPT
+      shell: bash
+      working-directory: undici
+      env:
+        CI: 'true'
+        WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json
+      run: npm run test:wpt || true
+    - name: Merge report
+      shell: bash
+      env:
+        NODE_WPT_REPORT: ${{ inputs.wpt-report }}
+        UNDICI_WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json
+      run: |
+        if [ -f "$UNDICI_WPT_REPORT" ]; then
+          jq -sc '
+            .[0].results += .[1].results |
+            .[0].time_end = .[1].time_end |
+            .[0]
+          ' "$NODE_WPT_REPORT" "$UNDICI_WPT_REPORT" > "${NODE_WPT_REPORT}.tmp"
+          mv "${NODE_WPT_REPORT}.tmp" "$NODE_WPT_REPORT"
+        fi

.github/actions/undici-wpt-legacy/action.yml

@@ -0,0 +1,37 @@
+name: Run undici WPT (legacy)
+description: Runs undici WPT tests for undici < 7 and appends results to the Node.js WPT report
+
+inputs:
+  undici-version:
+    required: true
+    description: undici version tag to checkout
+  wpt-report:
+    required: true
+    description: Path to the Node.js WPT report
+
+runs:
+  using: composite
+  steps:
+    - name: Checkout undici
+      uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+      with:
+        repository: nodejs/undici
+        persist-credentials: false
+        path: undici
+        clean: false
+        ref: ${{ inputs.undici-version }}
+    - name: Prepare WPT checkout
+      shell: bash
+      run: |
+        rm -rf undici/test/wpt/tests
+        mv test/fixtures/wpt undici/test/wpt/tests
+    - name: Install dependencies
+      shell: bash
+      working-directory: undici
+      run: npm install
+    - name: Run WPT
+      shell: bash
+      working-directory: undici
+      env:
+        WPT_REPORT: ${{ inputs.wpt-report }}
+      run: npm run test:wpt || true

.github/workflows/close-stale-feature-requests.yml

@@ -96,6 +96,48 @@ jobs:
             echo "WPT_REPORT=$(pwd)/out/wpt/wptreport.json" >> $GITHUB_ENV
           fi
 
+      # undici WPT Runner
+      - name: Set env.UNDICI_VERSION
+        if: ${{ env.WPT_REPORT != '' }}
+        run: |
+          UNDICI_VERSION=$(jq -r '.version' < deps/undici/src/package.json)
+          echo "UNDICI_VERSION=v$UNDICI_VERSION" >> $GITHUB_ENV
+          if [ "${UNDICI_VERSION%%.*}" -ge 7 ]; then
+            echo "UNDICI_WPT=current" >> $GITHUB_ENV
+          else
+            echo "UNDICI_WPT=legacy" >> $GITHUB_ENV
+          fi
+      # Checkout composite actions from the default branch since the
+      # version-specific checkout above overwrites .github/actions/
+      - name: Checkout undici WPT actions
+        if: ${{ env.WPT_REPORT != '' }}
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+        with:
+          sparse-checkout: |
+            .github/actions/undici-wpt-current
+            .github/actions/undici-wpt-legacy
+          sparse-checkout-cone-mode: false
+          persist-credentials: false
+          path: _wpt_actions
+          clean: false
+      - name: Place undici WPT actions
+        if: ${{ env.WPT_REPORT != '' }}
+        run: |
+          mkdir -p .github/actions
+          cp -r _wpt_actions/.github/actions/undici-wpt-* .github/actions/
+      - name: Run undici WPT (current)
+        if: ${{ env.UNDICI_WPT == 'current' }}
+        uses: ./.github/actions/undici-wpt-current
+        with:
+          undici-version: ${{ env.UNDICI_VERSION }}
+          wpt-report: ${{ env.WPT_REPORT }}
+      - name: Run undici WPT (legacy)
+        if: ${{ env.UNDICI_WPT == 'legacy' }}
+        uses: ./.github/actions/undici-wpt-legacy
+        with:
+          undici-version: ${{ env.UNDICI_VERSION }}
+          wpt-report: ${{ env.WPT_REPORT }}
+
       # Upload artifacts
       - name: Clone report for upload
         if: ${{ env.WPT_REPORT != '' }}

.github/workflows/close-stale-pull-requests.yml

@@ -20,9 +20,10 @@ jobs:
     steps:
       - name: Trigger update-links workflow on nodejs/release-cloudflare-worker
         run: |
-          gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker
+          gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker -f version=$VERSION
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+          VERSION: ${{ inputs.version || github.event.release.tag_name }}
 
       - name: Trigger create-release-post workflow on nodejs/nodejs.org
         run: |

.github/workflows/daily-wpt-fyi.yml

@@ -0,0 +1,50 @@
+name: Close stale
+on:
+  workflow_dispatch:
+  schedule:
+    # Run every day at 1:00 AM UTC.
+    - cron: 0 1 * * *
+
+# yamllint disable rule:empty-lines
+env:
+  CLOSE_MESSAGE: >
+    This {0} has been automatically closed after 30 days of inactivity
+    following its stale status (no activity for a total of 240 days).
+
+    If this is still relevant, feel free to reopen it or leave a comment
+    with additional details so we can continue the discussion.
+
+  WARN_MESSAGE: >
+    This {0} has been marked as stale due to 210 days of inactivity.
+
+    It will be automatically closed in 30 days if no further activity occurs.
+    If this is still relevant, please leave a comment or update it to keep it open.
+# yamllint enable
+
+permissions:
+  contents: read
+
+jobs:
+  stale:
+    permissions:
+      issues: write  # for actions/stale to close stale issues
+      pull-requests: write  # for actions/stale to close stale PRs
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-slim
+    steps:
+      - uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f  # v10.2.0
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          days-before-stale: 210
+          days-before-close: 30
+          stale-issue-label: stale
+          exempt-issue-labels: never-stale, confirmed-bug
+          close-issue-message: ${{ format(env.CLOSE_MESSAGE, 'issue') }}
+          stale-issue-message: ${{ format(env.WARN_MESSAGE, 'issue') }}
+          stale-pr-label: stale
+          exempt-pr-labels: never-stale
+          close-pr-message: ${{ format(env.CLOSE_MESSAGE, 'pull request') }}
+          stale-pr-message: ${{ format(env.WARN_MESSAGE, 'pull request') }}
+          # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
+          operations-per-run: 500
+          remove-stale-when-updated: true

.github/workflows/post-release.yml

@@ -77,9 +77,14 @@ jobs:
       - name: Environment Information
         run: npx envinfo
       - name: Build
-        run: make -C node build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --v8-enable-temporal-support"
+        working-directory: node
+        run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --v8-enable-temporal-support"
       - name: Test
-        run: make -C node test-ci -j1 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
+        working-directory: node
+        run: make test-ci -j1 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
+      - name: Ensure running tests did not cause any change in the tree
+        working-directory: node
+        run: git add -A && git diff --name-only --exit-code --staged
       - name: Re-run test in a folder whose name contains unusual chars
         run: |
           mv node "$DIR"

.github/workflows/stale.yml

@@ -196,7 +196,7 @@ jobs:
             --arg ccache "${NIX_SCCACHE:-null}" \
             --arg devTools '[]' \
             --arg benchmarkTools '[]' \
-            ${{ endsWith(matrix.system, '-darwin') && '--arg withAmaro false --arg withLief false --arg withSQLite false --arg extraConfigFlags ''["--without-inspector" "--without-node-options"]'' \' || '\' }}
+            ${{ endsWith(matrix.system, '-darwin') && '--arg withAmaro false --arg withLief false --arg withSQLite false --arg withFFI false --arg extraConfigFlags ''["--without-inspector" "--without-node-options"]'' \' || '\' }}
             --run '
                 make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9 --skip-tests=$CI_SKIP_TESTS"
             ' "$TAR_DIR/shell.nix"