Skip to content

Commit 8d72d50

Browse files
committed
Revert "deps: update libuv to 1.52.1"
This reverts commit 5bebd7e. The update appears to be causing persistent flakiness in test-http(s), test-net-*, and test-tls-* tests on Windows. The flakiness manifests as an abort apparently caused by a race condition introduced in connection cleanup on process teardown. Root cause still needs to be fully determined. Reverting the update will hopefully get us back to a stable state while the underlying issue is investigated and resolved.
1 parent e78ccd8 commit 8d72d50

122 files changed

Lines changed: 1390 additions & 2885 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

deps/uv/.clang-tidy

Lines changed: 0 additions & 47 deletions
This file was deleted.

deps/uv/.mailmap

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@ Jesse Gorzinski <[email protected]>
2727
2828
Juan José Arboleda <[email protected]>
2929
30-
3130
3231
33-
3432
3533
3634
@@ -44,8 +42,7 @@ Nick Logan <[email protected]> <[email protected]>
4442
4543
Rasmus Christian Pedersen <[email protected]>
4644
Rasmus Christian Pedersen <[email protected]> <[email protected]>
47-
48-
45+
4946
5047
5148
Ryan Emery <[email protected]>

deps/uv/AUTHORS

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ guworks <[email protected]>
210210
RossBencina <[email protected]>
211211
Roger A. Light <[email protected]>
212212
chenttuuvv <[email protected]>
213-
Richard Lau <richard.lau@ibm.com>
213+
Richard Lau <rlau@redhat.com>
214214
ronkorving <[email protected]>
215215
Corbin Simpson <[email protected]>
216216
Zachary Hamm <[email protected]>
@@ -604,33 +604,3 @@ mugitya03 <[email protected]>
604604
Itay Bookstein <[email protected]>
605605
606606
607-
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
608-
609-
610-
611-
Luca Saccarola <[email protected]>
612-
wisemanny <[email protected]>
613-
Sean Dewar <[email protected]>
614-
Lawrence Stubbs <[email protected]>
615-
616-
Anton Kirilov <[email protected]>
617-
Savas Sahin <[email protected]>
618-
619-
620-
621-
Christian Guinard <[email protected]>
622-
Gang Zhuo <[email protected]>
623-
Ayush Kumar <[email protected]>
624-
Ambuj Vashistha <[email protected]>
625-
Bart Louwers <[email protected]>
626-
Kartik Puri <[email protected]>
627-
Oblivionsage <[email protected]>
628-
Cody Tapscott <[email protected]>
629-
630-
631-
632-
StefanStojanovic <[email protected]>
633-
Przemysław Sobala <[email protected]>
634-
Quaylyn Rimer <[email protected]>
635-
Yasser Nascimento <[email protected]>
636-
Rudi Heitbaum <[email protected]>

deps/uv/CMakeLists.txt

Lines changed: 0 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ set(CMAKE_C_STANDARD 11)
2424

2525
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
2626

27-
2827
option(LIBUV_BUILD_SHARED "Build shared lib" ON)
2928

3029
cmake_dependent_option(LIBUV_BUILD_TESTS
@@ -701,8 +700,6 @@ if(LIBUV_BUILD_TESTS)
701700
test/test-udp-send-immediate.c
702701
test/test-udp-sendmmsg-error.c
703702
test/test-udp-send-unreachable.c
704-
test/test-udp-recv-cb-close-pollerr.c
705-
test/test-udp-recvmsg-unreachable-error.c
706703
test/test-udp-try-send.c
707704
test/test-udp-recv-in-a-row.c
708705
test/test-udp-reuseport.c
@@ -750,14 +747,6 @@ if(LIBUV_BUILD_TESTS)
750747
"$<TARGET_FILE:uv_run_tests_a>"
751748
"$<TARGET_FILE_DIR:uv_run_tests_a>/uv_run_tests_a_no_ext")
752749
endif()
753-
754-
if(QNX)
755-
install(TARGETS uv_run_tests uv_run_tests_a uv_run_benchmarks_a
756-
DESTINATION ${CMAKE_INSTALL_BINDIR}/libuv_tests)
757-
758-
install(DIRECTORY test/fixtures
759-
DESTINATION ${CMAKE_INSTALL_BINDIR}/libuv_tests)
760-
endif()
761750
endif()
762751

763752
# Now for some gibbering horrors from beyond the stars...
@@ -785,11 +774,6 @@ install(TARGETS uv_a EXPORT libuvConfig
785774
install(EXPORT libuvConfig
786775
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/libuv
787776
NAMESPACE libuv::)
788-
write_basic_package_version_file(libuvConfigVersion.cmake
789-
VERSION ${PACKAGE_VERSION}
790-
COMPATIBILITY SameMajorVersion)
791-
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libuvConfigVersion.cmake
792-
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/libuv)
793777

794778
if(LIBUV_BUILD_SHARED)
795779
# The version in the filename is mirroring the behaviour of autotools.
@@ -830,77 +814,3 @@ message(STATUS "summary of build options:
830814
C compiler: ${CMAKE_C_COMPILER} (${CMAKE_C_COMPILER_ID})
831815
CFLAGS: ${CMAKE_C_FLAGS_${_build_type}} ${CMAKE_C_FLAGS}
832816
")
833-
834-
# clang-tidy support
835-
option(ENABLE_CLANG_TIDY "Enable clang-tidy checks" ON)
836-
if(ENABLE_CLANG_TIDY)
837-
find_program(CLANG_TIDY_EXE NAMES "clang-tidy")
838-
if(CLANG_TIDY_EXE)
839-
set(CMAKE_C_CLANG_TIDY "${CLANG_TIDY_EXE}")
840-
message(STATUS "clang-tidy found: ${CLANG_TIDY_EXE}")
841-
else()
842-
set(CMAKE_C_CLANG_TIDY "clang-tidy")
843-
message(STATUS "clang-tidy not found: install clang-tidy or set -DCLANG_TIDY_EXE to run tidy analysis on this platform")
844-
endif()
845-
846-
# Collect source files from existing targets (deduplicated)
847-
set(ALL_SOURCE_FILES)
848-
set(SRC_TARGETS)
849-
set(TEST_TARGETS)
850-
set(TIDY_TARGETS)
851-
852-
# Add main library sources
853-
list(APPEND ALL_SOURCE_FILES ${uv_sources})
854-
855-
# Add test sources if tests are enabled
856-
if(LIBUV_BUILD_TESTS)
857-
list(APPEND ALL_SOURCE_FILES ${uv_test_sources})
858-
endif()
859-
860-
# Remove duplicates and non-existent files
861-
list(REMOVE_DUPLICATES ALL_SOURCE_FILES)
862-
863-
foreach(SOURCE_FILE ${ALL_SOURCE_FILES})
864-
# Create a clean target name
865-
string(REPLACE "/" "-" TARGET_NAME ${SOURCE_FILE})
866-
string(REGEX REPLACE "\\.[^.]*$" "" TARGET_NAME ${TARGET_NAME})
867-
set(FULL_TARGET_NAME "tidy-${TARGET_NAME}")
868-
869-
# Create individual target for this source file
870-
add_custom_target(${FULL_TARGET_NAME}
871-
COMMAND ${CMAKE_C_CLANG_TIDY} -p "${CMAKE_BINARY_DIR}" "${CMAKE_CURRENT_SOURCE_DIR}/${SOURCE_FILE}"
872-
COMMENT "Running clang-tidy on ${SOURCE_FILE}"
873-
VERBATIM)
874-
875-
# Add to appropriate folder list
876-
if(SOURCE_FILE MATCHES "^src/")
877-
list(APPEND SRC_TARGETS ${FULL_TARGET_NAME})
878-
elseif(SOURCE_FILE MATCHES "^test/")
879-
list(APPEND TEST_TARGETS ${FULL_TARGET_NAME})
880-
endif()
881-
882-
# Add to list of all tidy targets
883-
list(APPEND TIDY_TARGETS ${FULL_TARGET_NAME})
884-
endforeach()
885-
886-
# Create folder-based targets
887-
if(SRC_TARGETS)
888-
add_custom_target(tidy-src
889-
COMMENT "Running clang-tidy on src files"
890-
VERBATIM)
891-
add_dependencies(tidy-src ${SRC_TARGETS})
892-
endif()
893-
894-
if(TEST_TARGETS)
895-
add_custom_target(tidy-test
896-
COMMENT "Running clang-tidy on test files"
897-
VERBATIM)
898-
add_dependencies(tidy-test ${TEST_TARGETS})
899-
endif()
900-
901-
# Create main tidy target that depends on all individual targets
902-
add_custom_target(tidy
903-
COMMENT "Running clang-tidy on all source files"
904-
VERBATIM)
905-
add_dependencies(tidy ${TIDY_TARGETS})
906-
endif()

0 commit comments

Comments
 (0)