src: add validation for CLI arguments that don't take a value

Author: npaun

src/node_options-inl.h

@@ -268,6 +268,10 @@ inline std::string RequiresArgumentErr(const std::string& arg) {
   return arg + " requires an argument";
 }
 
+inline std::string UnexpectedArgumentErr(const std::string& arg) {
+  return arg + " does not take an argument";
+}
+
 inline std::string NegationImpliesBooleanError(const std::string& arg) {
   return arg + " is an invalid negation because it is not a boolean option";
 }
@@ -475,6 +479,10 @@ void OptionsParser<Options>::Parse(
             value = value.substr(1);  // Treat \- as escaping an -.
         }
       }
+    } else if (info.type == kBoolean && equals_index != std::string::npos) {
+      // Boolean options don't accept arguments
+      errors->push_back(UnexpectedArgumentErr(name));
+      break;
     }
 
     switch (info.type) {

test/parallel/test-cli-bad-options.js

@@ -17,6 +17,8 @@ requiresArgument('--eval');
 missingOption('--allow-fs-read=*', '--permission');
 missingOption('--allow-fs-write=*', '--permission');
 
+forbidsArgument('--check');
+
 function missingOption(option, requiredOption) {
   const r = spawnSync(process.execPath, [option], { encoding: 'utf8' });
   assert.strictEqual(r.status, 1);
@@ -36,3 +38,15 @@ function requiresArgument(option) {
     `${process.execPath}: ${option} requires an argument`
   );
 }
+
+function forbidsArgument(option) {
+  const r = spawnSync(process.execPath, [`${option}=invalid`], { encoding: 'utf8' });
+
+  assert.strictEqual(r.status, 9);
+
+  const msg = r.stderr.split(/\r?\n/)[0];
+  assert.strictEqual(
+    msg,
+    `${process.execPath}: ${option} does not take an argument`
+  );
+}