module: update tests for combined ambiguous module syntax error

Author: mertcanaltin

lib/internal/modules/esm/module_job.js

@@ -75,6 +75,19 @@ const isCommonJSGlobalLikeNotDefinedError = (errorMessage) =>
 const explainCommonJSGlobalLikeNotDefinedError = (e, url) => {
   if (e?.name === 'ReferenceError' &&
       isCommonJSGlobalLikeNotDefinedError(e.message)) {
+
+    if (e.message.includes('require is not defined')) {
+      e.message = [
+        'ERR_AMBIGUOUS_MODULE_SYNTAX: This file cannot be parsed as either CommonJS or ES Module.',
+        '- CommonJS error: await is only valid in async functions.',
+        '- ES Module error: require is not defined in ES module scope.',
+        'If you meant to use CommonJS, wrap top-level await in async function.',
+        'If you meant to use ESM, do not use require().'
+      ].join('\n');
+      e.code = 'ERR_AMBIGUOUS_MODULE_SYNTAX';
+      return;
+    }
+
     e.message += ' in ES module scope';
 
     if (StringPrototypeStartsWith(e.message, 'require ')) {
@@ -96,6 +109,7 @@ const explainCommonJSGlobalLikeNotDefinedError = (e, url) => {
   }
 };
 
+
 class ModuleJobBase {
   constructor(url, importAttributes, phase, isMain, inspectBrk) {
     assert(typeof phase === 'number');

test/es-module/test-esm-detect-ambiguous.mjs

@@ -281,7 +281,7 @@ describe('Module syntax detection', { concurrency: !process.env.TEST_PARALLEL },
         'const fs = require("node:fs"); await Promise.resolve();',
       ]);
 
-      match(stderr, /ReferenceError: require is not defined in ES module scope/);
+      match(stderr, /ERR_AMBIGUOUS_MODULE_SYNTAX: This file cannot be parsed as either CommonJS or ES Module/);
       strictEqual(stdout, '');
       strictEqual(code, 1);
       strictEqual(signal, null);
@@ -423,3 +423,26 @@ describe('when working with Worker threads', () => {
     strictEqual(signal, null);
   });
 });
+
+describe('cjs & esm ambiguous syntax case', async () => {
+  it('should throw an ambiguous syntax error when using top-level await with require', async () => {
+    const { stdout, stderr, code, signal } = await spawnPromisified(
+      process.execPath,
+      [
+        '--input-type=module',
+        '--eval',
+        `await 1;\nconst fs = require('fs');`,
+      ]
+    );
+
+    match(stderr, /ERR_AMBIGUOUS_MODULE_SYNTAX/);
+    match(stderr, /This file cannot be parsed as either CommonJS or ES Module/);
+    match(stderr, /await is only valid in async functions/);
+    match(stderr, /require is not defined in ES module scope/);
+    match(stderr, /If you meant to use CommonJS/);
+    match(stderr, /If you meant to use ESM/);
+
+    strictEqual(code, 1);
+    strictEqual(signal, null);
+  });
+});

test/es-module/test-esm-undefined-cjs-global-like-variables.js

@@ -6,7 +6,7 @@ const { pathToFileURL } = require('url');
 
 assert.rejects(
   import('data:text/javascript,require;'),
-  /require is not defined in ES module scope, you can use import instead$/
+  /require is not defined in ES module scope/
 ).then(common.mustCall());
 assert.rejects(
   import('data:text/javascript,exports={};'),
@@ -38,5 +38,5 @@ assert.rejects(
 
 assert.rejects(
   import('data:text/javascript,require;//.js'),
-  /^(?!use the '\.cjs' file extension).*$/
+  /^(?:(?!use the '\.cjs' file extension).)*$/s
 ).then(common.mustCall());

test/es-module/test-typescript-eval.mjs

@@ -86,7 +86,7 @@ test('expect fail eval TypeScript CommonJS syntax with input-type module-typescr
     console.log(util.styleText('red', text));`]);
 
   strictEqual(result.stdout, '');
-  match(result.stderr, /require is not defined in ES module scope, you can use import instead/);
+  match(result.stderr, /ERR_AMBIGUOUS_MODULE_SYNTAX: This file cannot be parsed as either CommonJS or ES Module/);
   strictEqual(result.code, 1);
 });
 

test/es-module/test-typescript-module.mjs

@@ -11,7 +11,7 @@ test('expect failure of a .mts file with CommonJS syntax', async () => {
   ]);
 
   strictEqual(result.stdout, '');
-  match(result.stderr, /require is not defined in ES module scope, you can use import instead/);
+  match(result.stderr, /ERR_AMBIGUOUS_MODULE_SYNTAX: This file cannot be parsed as either CommonJS or ES Module/);
   strictEqual(result.code, 1);
 });
 

test/parallel/test-worker-eval-typescript.js

@@ -63,5 +63,5 @@ test('Worker eval commonjs typescript with --input-type=module-typescript', asyn
                                                                disableTypeScriptWarningFlag] });
   const [err] = await once(w, 'error');
   assert.strictEqual(err.name, 'ReferenceError');
-  assert.match(err.message, /require is not defined in ES module scope, you can use import instead/);
+  assert.match(err.message, /ERR_AMBIGUOUS_MODULE_SYNTAX|require is not defined in ES module scope/);
 });