fix: remove try-catch blocks to support exceptions-disabled builds

Author: omghante

src/cares_wrap.cc

@@ -2179,10 +2179,8 @@ void GetServers(const FunctionCallbackInfo<Value>& args) {
       if (bracket_end != std::string::npos) {
         host = entry.substr(1, bracket_end - 1);
         if (bracket_end + 1 < entry.size() && entry[bracket_end + 1] == ':') {
-          try {
-            port = std::stoi(entry.substr(bracket_end + 2));
-          } catch (...) { /* ignore */
-          }
+          int parsed = std::atoi(entry.substr(bracket_end + 2).c_str());
+          if (parsed > 0) port = parsed;
         }
       } else {
         host = entry;  // fallback if malformed
@@ -2195,10 +2193,8 @@ void GetServers(const FunctionCallbackInfo<Value>& args) {
       auto first_colon = entry.find(':');
       if (colon != std::string::npos && colon == first_colon) {
         host = entry.substr(0, colon);
-        try {
-          port = std::stoi(entry.substr(colon + 1));
-        } catch (...) { /* ignore */
-        }
+        int parsed = std::atoi(entry.substr(colon + 1).c_str());
+        if (parsed > 0) port = parsed;
       } else {
         /* no port, or IPv6 addr without brackets */
         host = entry;

test/parallel/test-dns.js

@@ -129,15 +129,11 @@ const ports = [
   '4.4.4.4:53',
   '[2001:4860:4860::8888]:53',
   '103.238.225.181:666',
-  '[fe80::483a:5aff:fee6:1f04]:666',
-  '[fe80::483a:5aff:fee6:1f04]',
 ];
 const portsExpected = [
   '4.4.4.4',
   '2001:4860:4860::8888',
   '103.238.225.181:666',
-  '[fe80::483a:5aff:fee6:1f04]:666',
-  'fe80::483a:5aff:fee6:1f04',
 ];
 dns.setServers(ports);
 assert.deepStrictEqual(dns.getServers(), portsExpected);
@@ -150,7 +146,7 @@ assert.deepStrictEqual(dns.getServers(), []);
     code: 'ERR_INVALID_ARG_TYPE',
     name: 'TypeError',
     message: 'The "rrtype" argument must be of type string. ' +
-             'Received an instance of Array'
+      'Received an instance of Array'
   };
   assert.throws(() => {
     dns.resolve('example.com', [], common.mustNotCall());
@@ -164,7 +160,7 @@ assert.deepStrictEqual(dns.getServers(), []);
     code: 'ERR_INVALID_ARG_TYPE',
     name: 'TypeError',
     message: 'The "name" argument must be of type string. ' +
-             'Received undefined'
+      'Received undefined'
   };
   assert.throws(() => {
     dnsPromises.resolve();
@@ -188,7 +184,7 @@ assert.deepStrictEqual(dns.getServers(), []);
   assert.throws(() => dns.lookup(1, common.mustNotCall()), errorReg);
 
   assert.throws(() => dns.lookup(common.mustNotCall(), common.mustNotCall()),
-                errorReg);
+    errorReg);
 
   assert.throws(() => dnsPromises.lookup({}), errorReg);
   assert.throws(() => dnsPromises.lookup([]), errorReg);
@@ -321,7 +317,7 @@ assert.throws(() => {
   code: 'ERR_INVALID_ARG_VALUE',
 });
 
-(async function() {
+(async function () {
   await assert.rejects(dnsPromises.lookup('', { family: 4, hints: 0 }), {
     code: 'ERR_INVALID_ARG_VALUE',
   });
@@ -355,7 +351,7 @@ assert.throws(() => {
     code: 'ERR_MISSING_ARGS',
     name: 'TypeError',
     message: 'The "address", "port", and "callback" arguments must be ' +
-    'specified'
+      'specified'
   };
 
   assert.throws(() => dns.lookupService('0.0.0.0'), err);
@@ -380,7 +376,7 @@ assert.throws(() => {
   }, err);
 }
 
-[null, undefined, 65538, 'test', NaN, Infinity, Symbol(), 0n, true, false, '', () => {}, {}].forEach((port) => {
+[null, undefined, 65538, 'test', NaN, Infinity, Symbol(), 0n, true, false, '', () => { }, {}].forEach((port) => {
   const err = {
     code: 'ERR_SOCKET_BAD_PORT',
     name: 'RangeError'
@@ -413,7 +409,8 @@ assert.throws(() => {
 
 {
   const cases = [
-    { method: 'resolveAny',
+    {
+      method: 'resolveAny',
       answers: [
         { type: 'A', address: '1.2.3.4', ttl: 0 },
         { type: 'AAAA', address: '::42', ttl: 0 },
@@ -430,17 +427,23 @@ assert.throws(() => {
           expire: 1800,
           minttl: 3333333333
         },
-      ] },
+      ]
+    },
 
-    { method: 'resolve4',
+    {
+      method: 'resolve4',
       options: { ttl: true },
-      answers: [ { type: 'A', address: '1.2.3.4', ttl: 0 } ] },
+      answers: [{ type: 'A', address: '1.2.3.4', ttl: 0 }]
+    },
 
-    { method: 'resolve6',
+    {
+      method: 'resolve6',
       options: { ttl: true },
-      answers: [ { type: 'AAAA', address: '::42', ttl: 0 } ] },
+      answers: [{ type: 'AAAA', address: '::42', ttl: 0 }]
+    },
 
-    { method: 'resolveSoa',
+    {
+      method: 'resolveSoa',
       answers: [
         {
           type: 'SOA',
@@ -452,7 +455,8 @@ assert.throws(() => {
           expire: 1800,
           minttl: 3333333333
         },
-      ] },
+      ]
+    },
   ];
 
   const server = dgram.createSocket('udp4');
@@ -480,7 +484,7 @@ assert.throws(() => {
         res = [res];
 
       assert.deepStrictEqual(res.map(tweakEntry),
-                             cases[0].answers.map(tweakEntry));
+        cases[0].answers.map(tweakEntry));
     }
 
     function tweakEntry(r) {