stream: avoid extra promise allocation in createPromiseCallback

Signed-off-by: Antoine du Hamel <[email protected]>

Author: aduh95

lib/internal/per_context/primordials.js

@@ -243,6 +243,7 @@ function copyPrototype(src, dest, prefix) {
   copyPrototype(original.prototype, primordials, `${name}Prototype`);
 });
 
+
 // Create copies of abstract intrinsic objects that are not directly exposed
 // on the global object.
 // Refs: https://tc39.es/ecma262/#sec-%typedarray%-intrinsic-object
@@ -273,6 +274,7 @@ const {
   ArrayPrototypePushApply,
   ArrayPrototypeSlice,
   FinalizationRegistry,
+  FunctionPrototypeBind,
   FunctionPrototypeCall,
   Map,
   ObjectDefineProperties,
@@ -435,6 +437,12 @@ const SafePromise = makeSafe(
   class SafePromise extends Promise {},
 );
 
+{
+  // eslint-disable-next-line node-core/prefer-primordials
+  const OriginalPromiseTry = Promise.try;
+  primordials.BindPromiseTry = (fn) => FunctionPrototypeBind(OriginalPromiseTry, Promise, fn);
+}
+
 /**
  * Attaches a callback that is invoked when the Promise is settled (fulfilled or
  * rejected). The resolved value cannot be modified from the callback.

lib/internal/webstreams/util.js

@@ -7,10 +7,11 @@ const {
   ArrayPrototypePush,
   ArrayPrototypeShift,
   AsyncIteratorPrototype,
+  BindPromiseTry,
+  FunctionPrototypeBind,
   MathMax,
   NumberIsNaN,
   PromisePrototypeThen,
-  ReflectApply,
   ReflectGet,
   Symbol,
   Uint8Array,
@@ -164,7 +165,7 @@ function enqueueValueWithSize(controller, value, size) {
 
 function createPromiseCallback(name, fn, thisArg) {
   validateFunction(fn, name);
-  return async (...args) => ReflectApply(fn, thisArg, args);
+  return BindPromiseTry(thisArg === undefined ? fn : FunctionPrototypeBind(fn, thisArg));
 }
 
 function isPromisePending(promise) {