watch: try/catch instead of existsSync

Author: efekrskl

lib/internal/main/watch_mode.js

@@ -16,19 +16,18 @@ const {
 } = require('internal/process/pre_execution');
 const {
   triggerUncaughtException,
-  exitCodes: { kNoFailure },
+  exitCodes: {kNoFailure},
 } = internalBinding('errors');
-const { getOptionValue } = require('internal/options');
-const { FilesWatcher } = require('internal/watch_mode/files_watcher');
-const { green, blue, red, white, clear } = require('internal/util/colors');
-const { convertToValidSignal } = require('internal/util');
-
-const { spawn } = require('child_process');
-const { existsSync } = require('fs');
-const { inspect } = require('util');
-const { setTimeout, clearTimeout } = require('timers');
-const { resolve } = require('path');
-const { once } = require('events');
+const {getOptionValue} = require('internal/options');
+const {FilesWatcher} = require('internal/watch_mode/files_watcher');
+const {green, blue, red, white, clear} = require('internal/util/colors');
+const {convertToValidSignal} = require('internal/util');
+
+const {spawn} = require('child_process');
+const {inspect} = require('util');
+const {setTimeout, clearTimeout} = require('timers');
+const {resolve} = require('path');
+const {once} = require('events');
 
 prepareMainThreadExecution(false, false);
 markBootstrapComplete();
@@ -83,7 +82,7 @@ for (let i = 0; i < process.execArgv.length; i++) {
 
 ArrayPrototypePushApply(argsWithoutWatchOptions, kCommand);
 
-const watcher = new FilesWatcher({ debounce: 200, mode: kShouldFilterModules ? 'filter' : 'all' });
+const watcher = new FilesWatcher({debounce: 200, mode: kShouldFilterModules ? 'filter' : 'all'});
 ArrayPrototypeForEach(kWatchedPaths, (p) => watcher.watchPath(p));
 
 let graceTimer;
@@ -106,9 +105,13 @@ function start() {
   }
   if (kOptionalEnvFiles.length > 0) {
     ArrayPrototypeForEach(kOptionalEnvFiles, (file) => {
-      const resolvedPath = resolve(file);
-      if (existsSync(resolvedPath)) {
-        watcher.filterFile(resolvedPath);
+      try {
+        watcher.filterFile(resolve(file));
+      } catch (error) {
+        if (error?.code !== 'ENOENT' && error?.code !== 'ENOTDIR') {
+          throw error;
+        }
+        // Failed watching the file, ignore
       }
     });
   }
@@ -134,7 +137,7 @@ async function killAndWait(signal = kKillSignal, force = false) {
   }
   const onExit = once(child, 'exit');
   child.kill(signal);
-  const { 0: exitCode } = await onExit;
+  const {0: exitCode} = await onExit;
   return exitCode;
 }
 
@@ -167,6 +170,7 @@ async function stop(child) {
 }
 
 let restarting = false;
+
 async function restart(child) {
   if (restarting) return;
   restarting = true;
@@ -205,5 +209,6 @@ function signalHandler(signal) {
     process.exit(exitCode ?? kNoFailure);
   };
 }
+
 process.on('SIGTERM', signalHandler('SIGTERM'));
 process.on('SIGINT', signalHandler('SIGINT'));