Skip to content

Commit 50b8818

Browse files
committed
quic: disable building ngtcp2 examples
The ngtcp2 client and server examples are built with the intention of using them as reference implementations for future quic tests. However, as of ngtcp2 1.22.0, these examples require c++-23 libraries, which doesn't match the current Node.js build requirements. Signed-off-by: Renegade334 <[email protected]>
1 parent cee146f commit 50b8818

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

node.gypi

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,10 @@
469469
'./deps/ngtcp2/ngtcp2.gyp:ngtcp2',
470470
'./deps/ngtcp2/ngtcp2.gyp:nghttp3',
471471

472-
# For tests
473-
'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_server',
474-
'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_client',
472+
# Example implementations used in test suite
473+
# TODO(@nodejs/quic): re-enable once builds support c++-23 headers
474+
#'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_server',
475+
#'./deps/ngtcp2/ngtcp2.gyp:ngtcp2_test_client',
475476
],
476477
}],
477478
],

test/parallel/parallel.status

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ test-snapshot-incompatible: SKIP
2222
# https://github.com/nodejs/node/issues/53579
2323
test-snapshot-reproducible: SKIP
2424

25+
# ngtcp2's example implementations cannot be built without c++-23 headers.
26+
test-quic-test-client: SKIP
27+
test-quic-test-server: SKIP
28+
2529
[$system==win32]
2630
# https://github.com/nodejs/node/issues/59090
2731
test-inspector-network-fetch: PASS, FLAKY

0 commit comments

Comments
 (0)