vfs: remove SEAProvider export and hasSeaAssets

Users should use sea.getVfs() from node:sea instead of creating
SEAProvider directly. getVfs() returns null when not running as SEA,
making hasSeaAssets() redundant.

- Remove SEAProvider from node:vfs exports
- Remove hasSeaAssets() from node:sea
- Simplify embedding.js to just check getVfs() result
- Update documentation and tests

Author: mcollina

doc/api/single-executable-applications.md

@@ -189,11 +189,10 @@ To use the VFS with SEA:
 const fs = require('node:fs');
 const sea = require('node:sea');
 
-// Check if SEA assets are available
-if (sea.hasAssets()) {
-  // Initialize and mount the SEA VFS
-  const vfs = sea.getVfs();
+// Get the SEA VFS (returns null if not running as SEA)
+const vfs = sea.getVfs();
 
+if (vfs) {
   // Now you can use standard fs APIs to read bundled assets
   const config = JSON.parse(fs.readFileSync('/sea/config.json', 'utf8'));
   const data = fs.readFileSync('/sea/data/file.txt');

doc/api/vfs.md

@@ -468,27 +468,6 @@ myVfs.provider.setReadOnly();
 // myVfs.writeFileSync('/app/config.json', 'new content');
 ```
 
-## Class: `SEAProvider`
-
-<!-- YAML
-added: REPLACEME
--->
-
-The `SEAProvider` provides read-only access to assets bundled in a Single
-Executable Application (SEA). It can only be used when running as a SEA.
-
-```cjs
-const { create, SEAProvider } = require('node:vfs');
-
-// Only works in SEA builds
-try {
-  const seaVfs = create(new SEAProvider());
-  seaVfs.mount('/assets');
-} catch (err) {
-  console.log('Not running as SEA');
-}
-```
-
 ## Class: `RealFSProvider`
 
 <!-- YAML

lib/internal/vfs/sea.js

@@ -55,21 +55,7 @@ function getSeaVfs(options) {
   return cachedSeaVfs;
 }
 
-/**
- * Checks if SEA VFS is available (i.e., running as SEA with assets).
- * @returns {boolean}
- */
-function hasSeaAssets() {
-  if (!isSea()) {
-    return false;
-  }
-  const { getAssetKeys } = internalBinding('sea');
-  const keys = getAssetKeys() || [];
-  return keys.length > 0;
-}
-
 module.exports = {
   createSeaVfs,
   getSeaVfs,
-  hasSeaAssets,
 };

lib/sea.js

@@ -83,7 +83,6 @@ function getAssetKeys() {
 
 const {
   getSeaVfs: getVfs,
-  hasSeaAssets: hasAssets,
 } = require('internal/vfs/sea');
 
 module.exports = {
@@ -93,5 +92,4 @@ module.exports = {
   getAssetAsBlob,
   getAssetKeys,
   getVfs,
-  hasAssets,
 };

lib/vfs.js

@@ -1,34 +1,10 @@
 'use strict';
 
-const {
-  codes: {
-    ERR_INVALID_STATE,
-  },
-} = require('internal/errors');
 const { VirtualFileSystem } = require('internal/vfs/file_system');
 const { VirtualProvider } = require('internal/vfs/provider');
 const { MemoryProvider } = require('internal/vfs/providers/memory');
 const { RealFSProvider } = require('internal/vfs/providers/real');
 
-// SEAProvider is lazy-loaded to avoid loading SEA bindings when not needed
-let SEAProvider;
-
-function getSEAProvider() {
-  if (SEAProvider === undefined) {
-    try {
-      SEAProvider = require('internal/vfs/providers/sea').SEAProvider;
-    } catch {
-      // SEA bindings not available (not running in SEA)
-      SEAProvider = class SEAProviderUnavailable {
-        constructor() {
-          throw new ERR_INVALID_STATE('SEAProvider can only be used in a Single Executable Application');
-        }
-      };
-    }
-  }
-  return SEAProvider;
-}
-
 /**
  * Creates a new VirtualFileSystem instance.
  * @param {VirtualProvider} [provider] The provider to use (defaults to MemoryProvider)
@@ -54,7 +30,4 @@ module.exports = {
   VirtualProvider,
   MemoryProvider,
   RealFSProvider,
-  get SEAProvider() {
-    return getSEAProvider();
-  },
 };

test/fixtures/sea/vfs/sea.js

@@ -3,11 +3,6 @@ const fs = require('fs');
 const sea = require('node:sea');
 const assert = require('assert');
 
-// Test hasSeaAssets() returns true when we have assets
-const hasAssets = sea.hasAssets();
-assert.strictEqual(hasAssets, true, 'hasSeaAssets() should return true');
-console.log('hasSeaAssets:', hasAssets);
-
 // Test getSeaVfs() returns a VFS instance
 const vfs = sea.getVfs();
 assert.ok(vfs !== null, 'getSeaVfs() should not return null');

test/parallel/test-vfs-sea.js

@@ -9,13 +9,6 @@ const sea = require('node:sea');
 
 // Test that SEA functions are exported from sea module
 assert.strictEqual(typeof sea.getVfs, 'function');
-assert.strictEqual(typeof sea.hasAssets, 'function');
-
-// Test hasSeaAssets() returns false when not running as SEA
-{
-  const hasAssets = sea.hasAssets();
-  assert.strictEqual(hasAssets, false);
-}
 
 // Test getSeaVfs() returns null when not running as SEA
 {