net: fix SocketAddress.parse default port handling

Author: araujogui

lib/internal/socketaddress.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const {
+  NumberParseInt,
   ObjectSetPrototypeOf,
   Symbol,
 } = primordials;
@@ -153,18 +154,17 @@ class SocketAddress {
     // other pieces here that do... the destucturing, the SocketAddress
     // constructor, etc. So we wrap this in a try/catch to be safe.
     try {
-      const {
-        hostname: address,
-        port,
-      } = URLParse(`http://${input}`);
+      // url.port strips default HTTP ports (e.g. 80), so parse the port from
+      // the raw input string instead.
+      const { hostname: address } = URLParse(`http://${input}`);
       if (address.startsWith('[') && address.endsWith(']')) {
-        return new SocketAddress({
-          address: address.slice(1, -1),
-          port: port | 0,
-          family: 'ipv6',
-        });
+        const portStart = input.indexOf(']:');
+        const port = portStart !== -1 ? NumberParseInt(input.slice(portStart + 2), 10) || 0 : 0;
+        return new SocketAddress({ address: address.slice(1, -1), port, family: 'ipv6' });
       }
-      return new SocketAddress({ address, port: port | 0 });
+      const lastColon = input.lastIndexOf(':');
+      const port = lastColon !== -1 ? NumberParseInt(input.slice(lastColon + 1), 10) || 0 : 0;
+      return new SocketAddress({ address, port });
     } catch {
       // Ignore errors here. Return undefined if the input cannot
       // be successfully parsed or is not a proper socket address.

test/parallel/test-socketaddress.js

@@ -148,6 +148,9 @@ describe('net.SocketAddress...', () => {
       { input: '0x.0x.0', address: '0.0.0.0', port: 0, family: 'ipv4' },
       { input: '[1:0::]', address: '1::', port: 0, family: 'ipv6' },
       { input: '[1::8]:123', address: '1::8', port: 123, family: 'ipv6' },
+      { input: '127.0.0.1:80', address: '127.0.0.1', port: 80, family: 'ipv4' },
+      { input: '127.0.0.1:443', address: '127.0.0.1', port: 443, family: 'ipv4' },
+      { input: '[::1]:80', address: '::1', port: 80, family: 'ipv6' },
     ];
 
     good.forEach((i) => {