tools: implements a few nits on build-aarch64-linux-v8

Rename things, and merge some steps.

Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #63048
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: aduh95

.github/workflows/test-shared.yml

@@ -173,6 +173,8 @@ jobs:
     outputs:
       local-cache: ${{ steps.upload.outcome != 'skipped' && 'true' || '' }}
       matrix: ${{ steps.query.outputs.matrix }}
+    env:
+      HAS_CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN && 'true' }}
     steps:
       - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
         with:
@@ -189,58 +191,49 @@ jobs:
         with:
           extra_nix_config: sandbox = true
 
-      - name: Evaluate V8 derivation
+      - name: Evaluate V8 derivation, check its cache status
         id: v8-drv
         run: |
           V8_DRV=$(
             nix-instantiate -E "builtins.filter (p: p.pname == ''v8'') (import $TAR_DIR/shell.nix { useSeparateDerivationForV8=true; }).buildInputs"
           )
+          V8_STORE_PATH=$(nix-store -q --outputs "$V8_DRV")
           echo "V8_DRV=$V8_DRV" >> "$GITHUB_OUTPUT"
-          echo "STORE_PATH=$(nix-store -q --outputs "$V8_DRV")" >> "$GITHUB_OUTPUT"
-
-      - name: Check if available on Cachix
-        id: cachix-check
-        run: |
-          echo 'HAS_WRITE_TOKEN=${{ secrets.CACHIX_AUTH_TOKEN && 'true' }}' >> "$GITHUB_OUTPUT"
           set -x
           [ "$(curl -ISsw "%{http_code}" -o /dev/null "https://nodejs.cachix.org/$(basename ${V8_STORE_PATH%-v8-*}).narinfo")" != "200" ] ||
             echo "ALREADY_CACHED=true" >> "$GITHUB_OUTPUT"
-        env:
-          V8_STORE_PATH: ${{ steps.v8-drv.outputs.STORE_PATH }}
 
       - uses: cachix/cachix-action@1eb2ef646ac0255473d23a5907ad7b04ce94065c  # v17
-        if: ${{ steps.cachix-check.outputs.ALREADY_CACHED != 'true' }}
+        if: ${{ steps.v8-drv.outputs.ALREADY_CACHED != 'true' }}
         with:
           name: nodejs
           authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
 
-      - name: Build V8 derivation
-        if: ${{ steps.cachix-check.outputs.ALREADY_CACHED != 'true' }}
-        run: nix-store --export "$(nix-build "$V8_DRV")" > libv8
+      - name: Build V8 to cache it
+        if: ${{ steps.v8-drv.outputs.ALREADY_CACHED != 'true' }}
+        run: nix-store --export "$(nix-build "$V8_DRV")" > libv8-aarch64-linux.nar
         env:
           V8_DRV: ${{ steps.v8-drv.outputs.V8_DRV }}
 
-      - name: Upload libv8
-        if: ${{ steps.cachix-check.outputs.ALREADY_CACHED != 'true' && steps.cachix-check.outputs.HAS_WRITE_TOKEN != 'true' }}
+      - name: Upload libv8-aarch64-linux.nar
+        if: ${{ steps.v8-drv.outputs.ALREADY_CACHED != 'true' && env.HAS_CACHIX_AUTH_TOKEN != 'true' }}
         id: upload
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a  # v7.0.1
         with:
-          name: libv8
-          path: libv8
+          name: libv8-aarch64-linux.nar
+          path: libv8-aarch64-linux.nar
 
       - name: Collect matrix of support OpenSSL versions
         id: query
         run: |
-          {
-            echo 'matrix<<EOF'
+          echo "matrix=$(
             nix-instantiate --eval --strict --json -E "
               let
                 matrix = import $TAR_DIR/tools/nix/openssl-matrix.nix {};
               in
               builtins.map (attr: { inherit attr; inherit (builtins.getAttr attr matrix) name; }) (builtins.attrNames matrix)
             "
-            echo 'EOF'
-          } >> "$GITHUB_OUTPUT"
+          )" >> "$GITHUB_OUTPUT"
 
   # Builds and tests Node.js with shared libraries against every supported
   # OpenSSL release version available in the repo-pinned nixpkgs. The default
@@ -268,7 +261,7 @@ jobs:
       - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
         if: ${{ needs.build-aarch64-linux-v8.outputs.local-cache }}
         with:
-          name: libv8
+          name: libv8-aarch64-linux.nar
 
       - uses: ./.github/actions/build-shared
         name: Build and test Node.js
@@ -281,7 +274,7 @@ jobs:
           # release (e.g. `openssl-1.1.1w`) so EOL-with-extended-support
           # cycles evaluate without relaxing nixpkgs' meta check globally.
           extra-nix-flags: |
-            --arg useSeparateDerivationForV8 ${{ needs.build-aarch64-linux-v8.outputs.local-cache && '"$(nix-store --import < libv8)"' || 'true' }} \
+            --arg useSeparateDerivationForV8 ${{ needs.build-aarch64-linux-v8.outputs.local-cache && '"$(nix-store --import < libv8-aarch64-linux.nar)"' || 'true' }} \
             --arg sharedLibDeps "(import $TAR_DIR/tools/nix/sharedLibDeps.nix {}) // {
                 openssl = (import $TAR_DIR/tools/nix/openssl-matrix.nix {}).$OPENSSL_ATTR;
               }" \