Merge branch 'main' into ishabi/v8-islive-sample

Author: IlyasShabi

.github/workflows/linters.yml

@@ -154,7 +154,12 @@ jobs:
         run: |
           nix-shell -I nixpkgs=./tools/nix/pkgs.nix -p 'nixfmt-tree' --run '
             treefmt --quiet --ci
-          ' || git --no-pager diff --exit-code
+          ' && EXIT_CODE="$?" || EXIT_CODE="$?"
+          if [ "$EXIT_CODE" != "0" ]
+          then
+            git --no-pager diff || true
+            exit "$EXIT_CODE"
+          fi
 
   lint-py:
     if: github.event.pull_request.draft == false

.github/workflows/timezone-update.yml

@@ -57,7 +57,7 @@ jobs:
         with:
           author: Node.js GitHub Bot <[email protected]>
           body: |
-            This PR was generated by tools/timezone-update.yml.
+            This PR was generated by `.github/workflows/timezone-update.yml` and `tools/update-timezone.mjs`.
 
             Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data
 

BUILDING.md

@@ -404,11 +404,9 @@ If you are running tests before submitting a pull request, use:
 make -j4 test
 ```
 
-`make -j4 test` does a full check on the codebase, including running linters and
-documentation tests.
+`make -j4 test` does a full check on the codebase, including documentation tests.
 
-To run the linter without running tests, use
-`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
+To run the linter, use `make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
 
 To fix auto fixable JavaScript linting errors, use `make lint-js-fix`.
 

CHANGELOG.md

@@ -41,7 +41,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V25.md#25.8.1">25.8.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V25.md#25.8.2">25.8.2</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V25.md#25.8.1">25.8.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V25.md#25.8.0">25.8.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V25.md#25.7.0">25.7.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V25.md#25.6.1">25.6.1</a><br/>
@@ -55,7 +56,8 @@ release.
 <a href="doc/changelogs/CHANGELOG_V25.md#25.0.0">25.0.0</a><br/>
   </td>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V24.md#24.14.0">24.14.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V24.md#24.14.1">24.14.1</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V24.md#24.14.0">24.14.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V24.md#24.13.1">24.13.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V24.md#24.13.0">24.13.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V24.md#24.12.0">24.12.0</a><br/>
@@ -77,18 +79,22 @@ release.
 <a href="doc/changelogs/CHANGELOG_V24.md#24.0.0">24.0.0</a><br/>
   </td>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V22.md#22.22.1">22.22.1</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.22.0">22.22.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.21.1">22.21.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.21.0">22.21.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.20.0">22.20.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.19.0">22.19.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.18.0">22.18.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.17.1">22.17.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.17.0">22.17.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.16.0">22.16.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.15.1">22.15.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V22.md#22.15.0">22.15.0</a><br/>
+<b><a href="doc/changelogs/CHANGELOG_V23.md#23.11.0">23.11.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.10.0">23.10.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.9.0">23.9.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.8.0">23.8.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.7.0">23.7.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.6.1">23.6.1</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.6.0">23.6.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.5.0">23.5.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.4.0">23.4.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.3.0">23.3.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.2.0">23.2.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.1.0">23.1.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V23.md#23.0.0">23.0.0</a><br/>
+  </td>
+  <td valign="top">
+<b><a href="doc/changelogs/CHANGELOG_V22.md#22.15.0">22.15.0</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V22.md#22.14.0">22.14.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V22.md#22.13.1">22.13.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V22.md#22.13.0">22.13.0</a><br/>
@@ -109,7 +115,8 @@ release.
 <a href="doc/changelogs/CHANGELOG_V22.md#22.0.0">22.0.0</a><br/>
   </td>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V20.md#20.20.1">20.20.1</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V20.md#20.20.2">20.20.2</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V20.md#20.20.1">20.20.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V20.md#20.20.0">20.20.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V20.md#20.19.6">20.19.6</a><br/>
 <a href="doc/changelogs/CHANGELOG_V20.md#20.19.5">20.19.5</a><br/>

Makefile

@@ -338,7 +338,7 @@ coverage-run-js: ## Run JavaScript tests with coverage.
 
 .PHONY: test
 # This does not run tests of third-party libraries inside deps.
-test: all ## Run default tests, linters, and build docs.
+test: all ## Run default tests and build docs.
 	$(MAKE) -s tooltest
 	$(MAKE) -s build-addons
 	$(MAKE) -s build-js-native-api-tests
@@ -348,7 +348,7 @@ test: all ## Run default tests, linters, and build docs.
 	$(MAKE) -s jstest
 
 .PHONY: test-only
-test-only: all  ## Run default tests, without linters or building the docs.
+test-only: all  ## Run default tests without building the docs.
 	$(MAKE) build-addons
 	$(MAKE) build-js-native-api-tests
 	$(MAKE) build-node-api-tests

benchmark/buffers/buffer-indexof.js

@@ -19,7 +19,7 @@ const searchStrings = [
 
 const bench = common.createBenchmark(main, {
   search: searchStrings,
-  encoding: ['undefined', 'utf8', 'ucs2'],
+  encoding: ['undefined', 'utf8', 'ucs2', 'latin1'],
   type: ['buffer', 'string'],
   n: [5e4],
 }, {

benchmark/crypto/hash-stream-creation.js

@@ -5,15 +5,15 @@ const common = require('../common.js');
 const crypto = require('crypto');
 
 const bench = common.createBenchmark(main, {
-  writes: [500],
+  n: [500],
   algo: [ 'sha256', 'md5' ],
   type: ['asc', 'utf', 'buf'],
   out: ['hex', 'binary', 'buffer'],
   len: [2, 1024, 102400, 1024 * 1024],
   api: ['legacy', 'stream'],
 });
 
-function main({ api, type, len, out, writes, algo }) {
+function main({ api, type, len, out, n, algo }) {
   if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
     console.error('Crypto streams not available until v0.10');
     // Use the legacy, just so that we can compare them.
@@ -41,15 +41,15 @@ function main({ api, type, len, out, writes, algo }) {
   const fn = api === 'stream' ? streamWrite : legacyWrite;
 
   bench.start();
-  fn(algo, message, encoding, writes, len, out);
+  fn(algo, message, encoding, n, len, out);
 }
 
-function legacyWrite(algo, message, encoding, writes, len, outEnc) {
-  const written = writes * len;
+function legacyWrite(algo, message, encoding, n, len, outEnc) {
+  const written = n * len;
   const bits = written * 8;
   const gbits = bits / (1024 * 1024 * 1024);
 
-  while (writes-- > 0) {
+  while (n-- > 0) {
     const h = crypto.createHash(algo);
     h.update(message, encoding);
     h.digest(outEnc);
@@ -58,12 +58,12 @@ function legacyWrite(algo, message, encoding, writes, len, outEnc) {
   bench.end(gbits);
 }
 
-function streamWrite(algo, message, encoding, writes, len, outEnc) {
-  const written = writes * len;
+function streamWrite(algo, message, encoding, n, len, outEnc) {
+  const written = n * len;
   const bits = written * 8;
   const gbits = bits / (1024 * 1024 * 1024);
 
-  while (writes-- > 0) {
+  while (n-- > 0) {
     const h = crypto.createHash(algo);
 
     if (outEnc !== 'buffer')

benchmark/crypto/hash-stream-throughput.js

@@ -5,14 +5,14 @@ const common = require('../common.js');
 const crypto = require('crypto');
 
 const bench = common.createBenchmark(main, {
-  writes: [500],
+  n: [500],
   algo: ['sha1', 'sha256', 'sha512'],
   type: ['asc', 'utf', 'buf'],
   len: [2, 1024, 102400, 1024 * 1024],
   api: ['legacy', 'stream'],
 });
 
-function main({ api, type, len, algo, writes }) {
+function main({ api, type, len, algo, n }) {
   if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
     console.error('Crypto streams not available until v0.10');
     // Use the legacy, just so that we can compare them.
@@ -40,30 +40,30 @@ function main({ api, type, len, algo, writes }) {
   const fn = api === 'stream' ? streamWrite : legacyWrite;
 
   bench.start();
-  fn(algo, message, encoding, writes, len);
+  fn(algo, message, encoding, n, len);
 }
 
-function legacyWrite(algo, message, encoding, writes, len) {
-  const written = writes * len;
+function legacyWrite(algo, message, encoding, n, len) {
+  const written = n * len;
   const bits = written * 8;
   const gbits = bits / (1024 * 1024 * 1024);
   const h = crypto.createHash(algo);
 
-  while (writes-- > 0)
+  while (n-- > 0)
     h.update(message, encoding);
 
   h.digest();
 
   bench.end(gbits);
 }
 
-function streamWrite(algo, message, encoding, writes, len) {
-  const written = writes * len;
+function streamWrite(algo, message, encoding, n, len) {
+  const written = n * len;
   const bits = written * 8;
   const gbits = bits / (1024 * 1024 * 1024);
   const h = crypto.createHash(algo);
 
-  while (writes-- > 0)
+  while (n-- > 0)
     h.write(message, encoding);
 
   h.end();

benchmark/crypto/rsa-sign-verify-throughput.js

@@ -17,28 +17,28 @@ keylen_list.forEach((key) => {
 });
 
 const bench = common.createBenchmark(main, {
-  writes: [500],
+  n: [500],
   algo: ['SHA1', 'SHA224', 'SHA256', 'SHA384', 'SHA512'],
   keylen: keylen_list,
   len: [1024, 102400, 2 * 102400, 3 * 102400, 1024 * 1024],
 });
 
-function main({ len, algo, keylen, writes }) {
+function main({ len, algo, keylen, n }) {
   const message = Buffer.alloc(len, 'b');
   bench.start();
-  StreamWrite(algo, keylen, message, writes, len);
+  StreamWrite(algo, keylen, message, n, len);
 }
 
-function StreamWrite(algo, keylen, message, writes, len) {
-  const written = writes * len;
+function StreamWrite(algo, keylen, message, n, len) {
+  const written = n * len;
   const bits = written * 8;
   const kbits = bits / (1024);
 
   const privateKey = RSA_PrivatePem[keylen];
   const s = crypto.createSign(algo);
   const v = crypto.createVerify(algo);
 
-  while (writes-- > 0) {
+  while (n-- > 0) {
     s.update(message);
     v.update(message);
   }

benchmark/dgram/single-buffer.js

@@ -5,7 +5,7 @@ const common = require('../common.js');
 const dgram = require('dgram');
 const PORT = common.PORT;
 
-// `num` is the number of send requests to queue up each time.
+// `n` is the number of send requests to queue up each time.
 // Keep it reasonably high (>10) otherwise you're benchmarking the speed of
 // event loop cycles more than anything else.
 const bench = common.createBenchmark(main, {
@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
   dur: [5],
 });
 
-function main({ dur, len, num: n, type }) {
+function main({ dur, len, n, type }) {
   const chunk = Buffer.allocUnsafe(len);
   let sent = 0;
   let received = 0;