vfs: address aduh95 review comments

- Use kEmptyObject instead of {} for default options
- Add validateObject for options parameter validation
- Use isURL() instead of instanceof URL
- Use toPathIfFileURL() instead of manual URL handling
- Use FunctionPrototypeCall instead of .call()

Author: mcollina

lib/internal/vfs/module_hooks.js

@@ -4,13 +4,16 @@ const {
   ArrayPrototypeIndexOf,
   ArrayPrototypePush,
   ArrayPrototypeSplice,
+  FunctionPrototypeCall,
   StringPrototypeEndsWith,
   StringPrototypeStartsWith,
 } = primordials;
 
 const { dirname, isAbsolute, resolve } = require('path');
 const { normalizePath } = require('internal/vfs/router');
-const { pathToFileURL, fileURLToPath, URL } = require('internal/url');
+const { isURL, pathToFileURL, fileURLToPath, toPathIfFileURL, URL } = require('internal/url');
+const { kEmptyObject } = require('internal/util');
+const { validateObject } = require('internal/validators');
 const { createENOENT } = require('internal/vfs/errors');
 
 // Registry of active VFS instances
@@ -590,14 +593,14 @@ function installHooks() {
   // Override fs/promises.lstat (needed for async glob support)
   originalPromisesLstat = fsPromises.lstat;
   fsPromises.lstat = async function lstat(path, options) {
-    if (typeof path === 'string' || path instanceof URL) {
-      const pathStr = typeof path === 'string' ? path : path.pathname;
+    if (typeof path === 'string' || isURL(path)) {
+      const pathStr = toPathIfFileURL(path);
       const vfsResult = await findVFSForLstatAsync(pathStr);
       if (vfsResult !== null) {
         return vfsResult.stats;
       }
     }
-    return originalPromisesLstat.call(fsPromises, path, options);
+    return FunctionPrototypeCall(originalPromisesLstat, fsPromises, path, options);
   };
 
   // Override fs.watch
@@ -607,11 +610,14 @@ function installHooks() {
     if (typeof options === 'function') {
       listener = options;
       options = kEmptyObject;
+    } else if (options != null) {
+      validateObject(options, 'options');
+    } else {
+      options = kEmptyObject;
     }
-    options ??= {};
 
-    if (typeof filename === 'string' || filename instanceof URL) {
-      const pathStr = typeof filename === 'string' ? filename : filename.pathname;
+    if (typeof filename === 'string' || isURL(filename)) {
+      const pathStr = toPathIfFileURL(filename);
       const vfsResult = findVFSForWatch(pathStr);
       if (vfsResult !== null) {
         return vfsResult.vfs.watch(pathStr, options, listener);
@@ -626,45 +632,48 @@ function installHooks() {
     // Handle optional options argument
     if (typeof options === 'function') {
       listener = options;
-      options = {};
+      options = kEmptyObject;
+    } else if (options != null) {
+      validateObject(options, 'options');
+    } else {
+      options = kEmptyObject;
     }
-    options ??= {};
 
-    if (typeof filename === 'string' || filename instanceof URL) {
-      const pathStr = typeof filename === 'string' ? filename : filename.pathname;
+    if (typeof filename === 'string' || isURL(filename)) {
+      const pathStr = toPathIfFileURL(filename);
       const vfsResult = findVFSForWatch(pathStr);
       if (vfsResult !== null) {
         return vfsResult.vfs.watchFile(pathStr, options, listener);
       }
     }
-    return originalWatchFile.call(fs, filename, options, listener);
+    return FunctionPrototypeCall(originalWatchFile, fs, filename, options, listener);
   };
 
   // Override fs.unwatchFile
   originalUnwatchFile = fs.unwatchFile;
   fs.unwatchFile = function unwatchFile(filename, listener) {
-    if (typeof filename === 'string' || filename instanceof URL) {
-      const pathStr = typeof filename === 'string' ? filename : filename.pathname;
+    if (typeof filename === 'string' || isURL(filename)) {
+      const pathStr = toPathIfFileURL(filename);
       const vfsResult = findVFSForWatch(pathStr);
       if (vfsResult !== null) {
         vfsResult.vfs.unwatchFile(pathStr, listener);
         return;
       }
     }
-    return originalUnwatchFile.call(fs, filename, listener);
+    return FunctionPrototypeCall(originalUnwatchFile, fs, filename, listener);
   };
 
   // Override fs/promises.watch
   originalPromisesWatch = fsPromises.watch;
   fsPromises.watch = function watch(filename, options) {
-    if (typeof filename === 'string' || filename instanceof URL) {
-      const pathStr = typeof filename === 'string' ? filename : filename.pathname;
+    if (typeof filename === 'string' || isURL(filename)) {
+      const pathStr = toPathIfFileURL(filename);
       const vfsResult = findVFSForWatch(pathStr);
       if (vfsResult !== null) {
         return vfsResult.vfs.promises.watch(pathStr, options);
       }
     }
-    return originalPromisesWatch.call(fsPromises, filename, options);
+    return FunctionPrototypeCall(originalPromisesWatch, fsPromises, filename, options);
   };
 
   // Register ESM hooks using Module.registerHooks