fixup

Signed-off-by: Paolo Insogna <[email protected]>

Author: ShogunPanda

common.gypi

@@ -15,7 +15,7 @@
     'python%': 'python',
 
     'node_shared%': 'false',
-    'node_enable_experimentals%': 0,
+    'node_enable_experimentals%': 'false',
     'force_dynamic_crt%': 0,
     'node_use_v8_platform%': 'true',
     'node_use_bundled_v8%': 'true',
@@ -438,8 +438,8 @@
       }],
       # The defines bellow must include all things from the external_v8_defines
       # list in v8/BUILD.gn.
-      ['node_enable_experimentals==1', {
-        'defines': ['NODE_ENABLE_EXPERIMENTALS'],
+      ['node_enable_experimentals == "true"', {
+        'defines': ['EXPERIMENTALS_DEFAULT_VALUE=true'],
       }],
       ['v8_enable_v8_checks == 1', {
         'defines': ['V8_ENABLE_CHECKS'],

configure.py

@@ -1809,7 +1809,7 @@ def configure_node_cctest_sources(o):
 def configure_node(o):
   if options.dest_os == 'android':
     o['variables']['OS'] = 'android'
-  o['variables']['node_enable_experimentals'] = B(options.enable_all_experimentals)
+  o['variables']['node_enable_experimentals'] = b(options.enable_all_experimentals)
   o['variables']['node_prefix'] = options.prefix
   o['variables']['node_install_npm'] = b(not options.without_npm)
   o['variables']['node_install_corepack'] = b(options.with_corepack)

src/node_options.h

@@ -112,9 +112,7 @@ class DebugOptions : public Options {
                     std::vector<std::string>* argv) override;
 };
 
-#ifdef NODE_ENABLE_EXPERIMENTALS
-#define EXPERIMENTALS_DEFAULT_VALUE true
-#else
+#ifndef EXPERIMENTALS_DEFAULT_VALUE
 #define EXPERIMENTALS_DEFAULT_VALUE false
 #endif