fixup! lib: refactor internal webidl converters

Author: panva

lib/internal/webidl.js

@@ -612,7 +612,7 @@ function createEnumConverter(name, values) {
     // Step 2: throw unless S is one of the enumeration values.
     if (!E.has(S)) {
       throw makeException(
-        `value '${S}' is not a valid enum value of type ${name}.`,
+        `'${S}' is not a valid enum value of type ${name}.`,
         { __proto__: null, ...options, code: 'ERR_INVALID_ARG_VALUE' });
     }
 

test/parallel/test-internal-webidl.js

@@ -244,7 +244,7 @@ for (const value of [
   assert.throws(() => converter('three', opts), {
     name: 'TypeError',
     code: 'ERR_INVALID_ARG_VALUE',
-    message: "Prefix: Context value 'three' is not a valid enum value " +
+    message: "Prefix: Context 'three' is not a valid enum value " +
       'of type Example.',
   });
 }
@@ -512,6 +512,7 @@ assert.throws(() => webidl.requiredArguments(1, 2, opts), {
     __proto__: null,
     allowShared: true,
   };
+  assertInvalidArgType(() => converters.BufferSource(sab, allowShared));
   assert.strictEqual(converters.BufferSource(view, allowShared), view);
   assert.strictEqual(converters.Uint8Array(view, allowShared), view);
 

test/parallel/test-webcrypto-webidl.js

@@ -311,7 +311,7 @@ function assertJsonWebKey(actual, expected) {
     assert.throws(() => converters.KeyFormat(bad, opts), {
       name: 'TypeError',
       code: 'ERR_INVALID_ARG_VALUE',
-      message: `${prefix}: ${context} value '${bad}' is not a valid enum value of type KeyFormat.`,
+      message: `${prefix}: ${context} '${bad}' is not a valid enum value of type KeyFormat.`,
     });
   }
 }
@@ -339,7 +339,7 @@ function assertJsonWebKey(actual, expected) {
     assert.throws(() => converters.KeyUsage(bad, opts), {
       name: 'TypeError',
       code: 'ERR_INVALID_ARG_VALUE',
-      message: `${prefix}: ${context} value '${bad}' is not a valid enum value of type KeyUsage.`,
+      message: `${prefix}: ${context} '${bad}' is not a valid enum value of type KeyUsage.`,
     });
   }
 }