stream: disallow writing string chunk with 'buffer' encoding

Signed-off-by: Renegade334 <[email protected]>

Author: Renegade334

lib/internal/streams/writable.js

@@ -466,6 +466,9 @@ function _write(stream, chunk, encoding, cb) {
     }
 
     if (typeof chunk === 'string') {
+      if (encoding === 'buffer') {
+        throw new ERR_UNKNOWN_ENCODING(encoding);
+      }
       if ((state[kState] & kDecodeStrings) !== 0) {
         chunk = Buffer.from(chunk, encoding);
         encoding = 'buffer';

test/parallel/test-stream-base-typechecking.js

@@ -31,7 +31,7 @@ function test(autoDestroy) {
   {
     const w = new Writable({
       autoDestroy,
-      _write() {}
+      write() {}
     });
     w.end();
     expectError(w, ['asd'], 'ERR_STREAM_WRITE_AFTER_END');
@@ -40,34 +40,42 @@ function test(autoDestroy) {
   {
     const w = new Writable({
       autoDestroy,
-      _write() {}
+      write() {}
     });
     w.destroy();
   }
 
   {
     const w = new Writable({
       autoDestroy,
-      _write() {}
+      write() {}
     });
     expectError(w, [null], 'ERR_STREAM_NULL_VALUES', true);
   }
 
   {
     const w = new Writable({
       autoDestroy,
-      _write() {}
+      write() {}
     });
     expectError(w, [{}], 'ERR_INVALID_ARG_TYPE', true);
   }
 
   {
     const w = new Writable({
-      decodeStrings: false,
       autoDestroy,
-      _write() {}
+      write() {}
+    });
+    expectError(w, ['asd', 'buffer'], 'ERR_UNKNOWN_ENCODING', true);
+  }
+
+  {
+    const w = new Writable({
+      autoDestroy,
+      decodeStrings: false,
+      write() {}
     });
-    expectError(w, ['asd', 'noencoding'], 'ERR_UNKNOWN_ENCODING', true);
+    expectError(w, ['asd', 'buffer'], 'ERR_UNKNOWN_ENCODING', true);
   }
 }