Skip to content

Commit 1e929e2

Browse files
committed
fixup! fix(git-node): handle multi-line trailers
1 parent 127ba36 commit 1e929e2

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

lib/landing_session.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export default class LandingSession extends Session {
333333
const stillInTrailers = () => {
334334
const result = interpretTrailers(amended.join('\n'));
335335
return result.length && originalTrailers.startsWith(result.trim());
336-
}
336+
};
337337
for (let i = amended.length - 1; amended[i] === '' || stillInTrailers(); i--) {
338338
// Remove last line until git no longer detects any trailers
339339
amended.pop();

test/unit/amend.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,21 +115,21 @@ describe('LandingSession.prototype.generateAmendedMessage', () => {
115115
it('should handle multi-line trailers', async(t) => {
116116
const session = createSession();
117117
const result = await session.generateAmendedMessage(
118-
'subsystem: foobar\n\nSigned-off-by: Mike McCready\n <66998419+MikeMcC399@users.noreply.github.com>\n'
118+
'subsystem: foobar\n\nSigned-off-by: user1\n <foobar@users.noreply.github.com>\n'
119119
);
120120

121121
t.assert.strictEqual(result,
122-
'subsystem: foobar\n\nSigned-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>\nPR-URL: http://example.com/123\nReviewed-By: user1 <[email protected]>');
122+
'subsystem: foobar\n\nSigned-off-by: user1 <foobar@users.noreply.github.com>\nPR-URL: http://example.com/123\nReviewed-By: user1 <[email protected]>');
123123
});
124124

125125
it('should not remove lines that look like trailers in the commit body', async(t) => {
126126
const session = createSession();
127127
const result = await session.generateAmendedMessage(
128-
'subsystem: foobar\n\nNot-A-Trailer: http://example.com/\n\nSigned-off-by: Mike McCready\n <66998419+MikeMcC399@users.noreply.github.com>\n'
128+
'subsystem: foobar\n\nNot-A-Trailer: http://example.com/\n\nSigned-off-by: user1\n <foobar@users.noreply.github.com>\n'
129129
);
130130

131131
t.assert.strictEqual(result,
132-
'subsystem: foobar\n\nNot-A-Trailer: http://example.com/\n\nSigned-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>\nPR-URL: http://example.com/123\nReviewed-By: user1 <[email protected]>');
132+
'subsystem: foobar\n\nNot-A-Trailer: http://example.com/\n\nSigned-off-by: user1 <foobar@users.noreply.github.com>\nPR-URL: http://example.com/123\nReviewed-By: user1 <[email protected]>');
133133
});
134134

135135
it('should handle cherry-pick from upstream', async(t) => {

0 commit comments

Comments
 (0)