Skip to content

How this repo is mantained

Jump to bottom
Antoine du Hamel edited this page Jul 31, 2022 · 4 revisions

This repo is a user-land port of node:test commits are chrry-picked from node core, using this procedure:

git fetch https://github.com/nodejs/node.git main
git cherry-pick -x FETCH_HEAD # instead of FETCH_HEAD, you can use a commit SHA
# ... resolve conflicts ...
# replace the URL in the files with the new git SHA
npm run test:lint:fix && npm run test:unit
# fix the failing tests, add the missing primordials, etc.
npm run test:lint:fix && npm run test:unit
git add .
git commit -S

A few things to have in mind:

  • primordials is not available on user-land modules, replace it with require('#internal/per_context/primordials').
  • It's likely you'll need to add primordials in lib/internal/per_context/primordials.js.
  • User-land modules should not depend on internal/ modules. Instead, replace internal/ with #internal/, and ensure the linked module is compatible.
  • Tests should not be altered, unless there's a good reason for it. When a test doesn't pass, it usually means there's a bug in the library code (so it should be fixed in lib/), or there's a difference between our test env and the Node.js one (in which case, the fix should probably happen in test/common/).

Clone this wiki locally