Skip to content

2021-04-06.md

Latest commit

 

History

History
36 lines (23 loc) · 1.49 KB

2021-04-06.md

File metadata and controls

36 lines (23 loc) · 1.49 KB

Node.js Loaders Team Meeting 2021-04-06

Links

Present

  • Geoffrey Booth (@GeoffreyBooth)
  • Derek Lewis (@DerekNonGeneric)
  • Jacob Smith (@JakobJingleheimer)
  • Gerhard Stöbich (@Flarna)
  • Bradley Farias (@bmeck)
  • Bryan English (@bengl)

Agenda

Notes

Missing use cases:

  • Need to add a communications channel to getGlobalPreloadCode; currently Gil Tayor works around this via a global, but we want to pass in a function instead. Get loaders off the main thread, so that we can intercept CommonJS require. Previously there were objections because of starting a thread on boot, but those objectors have moved on from the project. This can happen later; unrelated to loader hooks design.
  • Mocks
  • Instrumentation

Needing to use command flags is a pain point for instrumentation

  • Bradley: spawning a worker thread could have loader hooks included in it, so that could maybe be a way for an instrumentation library to load first and spawn a new thread that would be the main thread for the application.

Discussion of how we got here, to the redesign from the current design; why we can’t reduce the resolve/load hooks down to just one hook.

@JakobJingleheimer is continuing work on nodejs/node#37468 and we will reconvence at the next meeting to discuss its progress.