core-validate-commit/test/rules/co-authored-by-is-trailer.js at f0d5329f625ab3b54a3af68c2677004631093838 · nodejs/core-validate-commit · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
import { test } from 'tap'
import Rule from '../../lib/rules/co-authored-by-is-trailer.js'
import Commit from 'gitlint-parser-node'
import Validator from '../../index.js'

test('rule: co-authored-by-is-trailer', (t) => {
  t.test('no co-authors', (tt) => {
    tt.plan(4)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'test: fix something\n' +
               '\n' +
               'fhqwhgads'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'no Co-authored-by metadata', 'message')
      tt.equal(opts.level, 'pass', 'level')
    }

    Rule.validate(context)
  })

  t.test('no empty lines above', (tt) => {
    tt.plan(7)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'test: fix something\n' +
               'Co-authored-by: Someone <[email protected]>'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'Co-authored-by must be a trailer', 'message')
      tt.equal(opts.string, 'Co-authored-by: Someone <[email protected]>', 'string')
      tt.equal(opts.line, 0, 'line')
      tt.equal(opts.column, 0, 'column')
      tt.equal(opts.level, 'fail', 'level')
    }

    Rule.validate(context)
  })

  t.test('quoting another commit message', (tt) => {
    tt.plan(4)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'deps: v8: cherry-pick deadbeef\n' +
               '\n' +
               'Original commit message:' +
               '\n' +
               '    Some description.\n' +
               '\n' +
               '    Co-authored-by: Someone <[email protected]>\n' +
               '\n' +
               'Reviewed-By: Bar <[email protected]>'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'no Co-authored-by metadata', 'message')
      tt.equal(opts.level, 'pass', 'level')
    }

    Rule.validate(context)
  })

  t.test('not trailer', (tt) => {
    tt.plan(7)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'test: fix something\n' +
               '\n' +
               'Some description.\n' +
               '\n' +
               'Co-authored-by: Someone <[email protected]>\n' +
               '\n' +
               'Reviewed-By: Bar <[email protected]>'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'Co-authored-by must be a trailer', 'message')
      tt.equal(opts.string, 'Co-authored-by: Someone <[email protected]>', 'string')
      tt.equal(opts.line, 3, 'line')
      tt.equal(opts.column, 0, 'column')
      tt.equal(opts.level, 'fail', 'level')
    }

    Rule.validate(context)
  })

  t.test('not all are trailers', (tt) => {
    tt.plan(7)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'test: fix something\n' +
               '\n' +
               'Some description.\n' +
               '\n' +
               'Co-authored-by: Someone <[email protected]>\n' +
               '\n' +
               'Co-authored-by: Someone Else <[email protected]>\n' +
               'Reviewed-By: Bar <[email protected]>'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'Co-authored-by must be a trailer', 'message')
      tt.equal(opts.string, 'Co-authored-by: Someone <[email protected]>', 'string')
      tt.equal(opts.line, 3, 'line')
      tt.equal(opts.column, 0, 'column')
      tt.equal(opts.level, 'fail', 'level')
    }

    Rule.validate(context)
  })

  t.test('is trailer', (tt) => {
    tt.plan(4)
    const v = new Validator()
    const context = new Commit({
      sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea',
      author: {
        name: 'Foo',
        email: '[email protected]',
        date: '2016-04-12T19:42:23Z'
      },
      message: 'test: fix something\n' +
               '\n' +
               'Some description.\n' +
               '\n' +
               'More description.\n' +
               '\n' +
               'Co-authored-by: Someone <[email protected]>\n' +
               'Reviewed-By: Bar <[email protected]>'
    }, v)

    context.report = (opts) => {
      tt.pass('called report')
      tt.equal(opts.id, 'co-authored-by-is-trailer', 'id')
      tt.equal(opts.message, 'Co-authored-by is a trailer', 'message')
      tt.equal(opts.level, 'pass', 'level')
    }

    Rule.validate(context)
  })

  t.end()
})