Skip to content

Commit 508d741

Browse files
committed
Test runner needs to add the SystemOverloadedError label for the pre-handshake network timeout
1 parent 41b2773 commit 508d741

3 files changed

Lines changed: 1 addition & 13 deletions

File tree

driver-core/src/test/unit/com/mongodb/internal/connection/AbstractServerDiscoveryAndMonitoringTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ protected void applyApplicationError(final BsonDocument applicationError) {
112112

113113
switch (when) {
114114
case "beforeHandshakeCompletes":
115+
BackpressureErrorLabeler.applyLabelsIfEligible(exception);
115116
server.sdamServerDescriptionManager().handleExceptionBeforeHandshake(
116117
SdamIssue.of(exception, new SdamIssue.Context(server.serverId(), errorGeneration, maxWireVersion)));
117118
break;

driver-core/src/test/unit/com/mongodb/internal/connection/ServerDiscoveryAndMonitoringTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ public class ServerDiscoveryAndMonitoringTest extends AbstractServerDiscoveryAnd
5454

5555
public ServerDiscoveryAndMonitoringTest(final String description, final BsonDocument definition) {
5656
super(definition);
57-
assumeFalse("https://jira.mongodb.org/browse/JAVA-5949",
58-
description.equals("error_handling_handshake.json: Network timeouts before and after the handshake completes"));
59-
6057
this.description = description;
6158
init(serverAddress -> NO_OP_SERVER_LISTENER, NO_OP_CLUSTER_LISTENER);
6259
}

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -439,16 +439,6 @@ public static void applyCustomizations(final TestDef def) {
439439
.file("server-discovery-and-monitoring", "pool-clear-on-error-checkout");
440440
def.skipJira("https://jira.mongodb.org/browse/JAVA-5664")
441441
.file("server-discovery-and-monitoring", "pool-cleared-on-min-pool-size-population-error");
442-
def.skipJira("https://jira.mongodb.org/browse/JAVA-5949")
443-
.file("server-discovery-and-monitoring", "backpressure-network-error-fail-single");
444-
def.skipJira("https://jira.mongodb.org/browse/JAVA-5949")
445-
.file("server-discovery-and-monitoring", "backpressure-network-timeout-error-single");
446-
def.skipJira("https://jira.mongodb.org/browse/JAVA-5949")
447-
.file("server-discovery-and-monitoring", "backpressure-network-error-fail-replicaset");
448-
def.skipJira("https://jira.mongodb.org/browse/JAVA-5949")
449-
.file("server-discovery-and-monitoring", "backpressure-network-timeout-error-replicaset");
450-
def.skipJira("https://jira.mongodb.org/browse/JAVA-5949")
451-
.file("server-discovery-and-monitoring", "backpressure-server-description-unchanged-on-min-pool-size-population-error");
452442

453443
// session tests
454444
def.skipJira("https://jira.mongodb.org/browse/JAVA-5968")

0 commit comments

Comments
 (0)