Merge branch 'main' into dependabot/github_actions/ossf/scorecard-action-2.4.0

Author: shivashankar-vaddepally

.github/workflows/lint.yml

@@ -27,8 +27,14 @@ jobs:
     steps:
       # Important: This sets up your GITHUB_WORKSPACE environment variable
       - uses: actions/checkout@v4
+      - name: Set up Python 3.11
+        uses: actions/setup-python@v6
+        with:
+          python-version: 3.11
+      - name: Install ansible-lint
+        run: python -m pip install ansible-lint
       - name: Run ansible-lint
-        uses: ansible/ansible-lint@main
+        run: ansible-lint
       - name: Upload SARIF file
         uses: github/codeql-action/upload-sarif@v3
         with:

.github/workflows/test.yml

@@ -115,8 +115,8 @@ jobs:
         python-version:
           - 3.11
         netscaler-version:
-          - 13.1-49.15
-          - 14.1-4.42
+          - 13.1-59.19
+          - 14.1-43.50
     steps:
       - name: Checkout the repo
         uses: actions/checkout@v4

.gitignore

@@ -1,6 +1,5 @@
 .vscode/
 
-tools/
 issues/
 
 plugins/module_utils/test.ipynb

CHANGELOG.md

@@ -7,6 +7,40 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.11.0] - 2025-10-31
+
+# Added 
+
+- Supporting dynamicRouting Protocols in netscaler.adc collections
+
+# Fixed
+
+- corrected sslhsmkey behaviour in collection
+- correcting entries in runtime.yml to include new supported resources in module_defaults
+
+# Fixed
+
+- Resolved error with `ssh_netscaler_adc` connection plugin with newer versions of ansible
+
+## [2.10.1] - 2025-09-16
+
+# Fixed 
+
+- Resolved error while importing new SSL certificate with duplicate primary key error
+
+## [2.10.0] - 2025-08-22
+
+### Added
+
+- Added migration tool to convert `citrix.adc` module playbooks to `netscaler.adc`.
+
+### Fixed 
+
+- Added option to skip non-updatable resources or fail explicitly
+- Removal of basic authentication from Netscaler ADC Ansible collection
+- Fixed idempotency issue in rename operations
+- Fixed GET request URL for global bindings to include type query parameter
+
 ## [2.9.2] - 2025-06-25
 
 ### Fixed 
@@ -177,7 +211,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Initial Release
-[unreleased]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.9.2...HEAD
+
+[unreleased]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.11.0...HEAD
+[2.11.0]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.10.1...2.11.0
+[2.10.1]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.10.0...2.10.1
+[2.10.0]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.9.2...2.10.0
 [2.9.2]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.9.1...2.9.2
 [2.9.1]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.9.0...2.9.1
 [2.9.0]: https://github.com/netscaler/ansible-collection-netscaleradc/compare/2.8.0...2.9.0

Makefile

@@ -2,16 +2,19 @@ fmt:
 	autoflake plugins/modules/*.py
 	autoflake plugins/module_utils/*.py
 	autoflake --recursive tests/
+	autoflake tools/migrationtool/*.py
 
 	black plugins/modules/*.py
 	black plugins/module_utils/*.py
 	black tests/
+	black tools/migrationtool/*.py
 
 	isort plugins/modules/*.py
 	isort plugins/module_utils/*.py
 	isort tests/
+	isort tools/migrationtool/*.py
 
-	yamlfmt .
+	yamlfmt $(shell find . -name '*.yml' -o -name '*.yaml')
 
 install:
 	ansible-galaxy collection install . --force
@@ -39,7 +42,7 @@ build:
 	ansible-galaxy collection build --force
 
 galaxy_importer: build
-	python3 -m galaxy_importer.main netscaler-adc-2.9.1.tar.gz
+	python3 -m galaxy_importer.main netscaler-adc-2.11.0.tar.gz
 
 # build_docs:
 # 	rm -rf _built_docs
@@ -60,7 +63,7 @@ galaxy_importer: build
 # skip the playbook which contains "password" in the file name
 run_examples:
 	@for playbook in examples/*.yaml; do \
-		if [[ $$playbook == *"password"* || $$playbook == *"login"* || $$playbook == *"logout"* || $$playbook == *"route"* || $$playbook == locationfile.yaml || $$playbook == nsip6.yaml || $$playbook == hanode.yaml ]]; then \
+		if [[ $$playbook == *"password"* || $$playbook == *"login"* || $$playbook == *"logout"* || $$playbook == *"route"* || $$playbook == *"locationfile.yaml"* || $$playbook == *"nsip6.yaml"* || $$playbook == *"hanode.yaml"* ]]; then \
 			continue; \
 		fi; \
 		echo "Running $$playbook"; \

README.md

@@ -157,6 +157,62 @@ export NETSCALER_NITRO_AUTH_TOKEN=$(curl -X POST -H "Content-Type:application/js
 echo $echo $NETSCALER_NITRO_AUTH_TOKEN
 ```
 
+### Migration Tool
+
+The collection includes a migration tool to help convert existing Ansible playbooks from the legacy `citrix.adc` collection to the new `netscaler.adc` collection format. This tool simplifies the transition from legacy automation to the updated collection.
+
+#### Features
+
+- **Module Mapping**: Automatically converts `citrix.adc` modules to `netscaler.adc` modules
+- **NITRO Request Conversion**: Transforms `citrix_adc_nitro_request` tasks to specific resource modules
+- **State Conversion**: Maps legacy operations (`add`, `update`, `delete`) to appropriate state values
+- **Credential Preservation**: Maintains authentication parameters and playbook structure
+- **YAML Structure Preservation**: Keeps task names, variables, and organization intact
+
+#### Usage
+
+```bash
+# Basic conversion
+python3 migrationtool/convert_yaml.py -i legacy_playbook.yaml -o migrated_playbook.yaml
+
+# With verbose output
+python3 migrationtool/convert_yaml.py -i legacy_playbook.yaml -o migrated_playbook.yaml -v
+```
+
+#### Example Conversion
+
+**Before (Legacy citrix.adc):**
+```yaml
+- name: Configure LB vserver
+  citrix_adc_nitro_request:
+    nsip: "{{ nsip }}"
+    nitro_user: "{{ nitro_user }}"
+    nitro_pass: "{{ nitro_pass }}"
+    operation: add
+    resource: lbvserver
+    name: my_lb_vserver
+    attributes:
+      servicetype: HTTP
+      ipv46: 10.10.10.10
+      port: 80
+```
+
+**After (New netscaler.adc):**
+```yaml
+- name: Configure LB vserver
+  netscaler.adc.lbvserver:
+    nsip: "{{ nsip }}"
+    nitro_user: "{{ nitro_user }}"
+    nitro_pass: "{{ nitro_pass }}"
+    state: present
+    name: my_lb_vserver
+    servicetype: HTTP
+    ipv46: 10.10.10.10
+    port: 80
+```
+
+For detailed migration tool documentation, usage examples, and troubleshooting, refer to the [Migration Tool README](https://github.com/netscaler/ansible-collection-netscaleradc/blob/main/tools/migrationtool/README.md).
+
 ### Invocation
 
 The credentials of the netscaler can be provided either in the playbook by hardcoding or defining in a inventory.ini file.
@@ -183,9 +239,9 @@ For external contributions, refer the [guidelines](https://github.com/netscaler/
 
 ## Support
 
-For issues : https://github.com/netscaler/ansible-collection-netscaleradc/issues
+As Red Hat Ansible Certified Content, this collection is entitled to support through the Ansible Automation Platform (AAP) using the **Create issue** button on the top right corner. If a support case cannot be opened with Red Hat and the collection has been obtained either from Galaxy or GitHub, we strongly encourage engaging with the NetScaler and Ansible community. You can contribute to the collection or seek assistance via the [NetScaler's Official GitHub Repository](https://github.com/netscaler/ansible-collection-netscaleradc) or connect with other Ansible users on the [Ansible Forum](https://forum.ansible.com/).
 
-For discussions or feature requests: https://github.com/netscaler/ansible-collection-netscaleradc/discussions
+For feature requests: https://github.com/netscaler/ansible-collection-netscaleradc/discussions
 
 ## Release Notes
 

examples/accesslist.yaml

@@ -0,0 +1,14 @@
+---
+- name: Configure accessslist
+  hosts: localhost
+  tasks:
+    - name: Create accesslist
+      delegate_to: localhost
+      netscaler.adc.accesslist:
+        state: present
+        id: 1
+        remark: "Allow all traffic"
+        rules:
+          - action: permit
+            address: 2.1.1.21
+            wildcard: "0.0.0.255"

examples/bfdinterface.yaml

@@ -0,0 +1,13 @@
+---
+- name: Configure bfdinterface
+  hosts: localhost
+  tasks:
+    - name: Create bfdinterface
+      delegate_to: localhost
+      netscaler.adc.bfdinterface:
+        state: present
+        name: vlan0
+        passive: true
+        interval: 752
+        minrx: 501
+        multiplier: 3

examples/bgprouter.yaml

@@ -0,0 +1,32 @@
+---
+- name: Sample bgprouter playbook
+  hosts: localhost
+  gather_facts: false
+  tasks:
+    - name: Configure bgprouter
+      delegate_to: localhost
+      netscaler.adc.bgprouter:
+        state: present
+
+        localAS: 122
+        routerId: "2.2.2.2"
+        afParams:
+          - addressFamily: "ipv4"
+            redistribute:
+              - protocol: "static"
+                routeMap: "test"
+          - addressFamily: "ipv6"
+        neighbor:
+          - address: "44.1.1.33"
+            remoteAS: 300
+            ASOriginationInterval: 11
+            advertisementInterval: 34
+            updateSource: "vlan101"
+            singlehopBfd: false
+            multihopBfd: false
+            afParams:
+              - addressFamily: "ipv4"
+                routeMap:
+                  - name: "test"
+                    direction: "out"
+              - addressFamily: "ipv6"

examples/iproute.yaml

@@ -0,0 +1,12 @@
+---
+- name: Configure bfdinterface
+  hosts: localhost
+  tasks:
+    - name: Create bfdinterface
+      delegate_to: localhost
+      netscaler.adc.iproute:
+        state: present
+        addressFamily: ipv4
+        prefix: 33.1.1.0
+        prefixLength: 24
+        nextHop: 10.106.210.24