Fix security issues flagged in PR #593 code scanning.

Signed-off-by: lakshmj <[email protected]>

Author: lakshmj

plugins/modules/nslaslicense_offline.py

@@ -43,14 +43,12 @@
       - Can also be set via the C(NETSCALER_NITRO_USER) environment variable.
     type: str
     required: true
-    no_log: true
   nitro_pass:
     description:
       - The password for the NetScaler ADC appliance.
       - Can also be set via the C(NETSCALER_NITRO_PASS) environment variable.
     type: str
     required: true
-    no_log: true
   nitro_protocol:
     description:
       - Protocol used to communicate with the NITRO API.
@@ -148,7 +146,6 @@
     las_secrets_json: /etc/netscaler/zmcd_secrets.json
 
 """
-
 RETURN = r"""
 ---
 changed:
@@ -213,7 +210,7 @@ def main():
         request_pem=dict(required=True, type="str"),
         request_ed=dict(required=True, type="str", choices=["Advanced", "Premium", "Standard"]),
         is_fips=dict(type="bool", default=False),
-        las_secrets_json=dict(required=True, type="str"),
+        las_secrets_json=dict(required=True, type="str", no_log=False),
         host_key_checking=dict(type="bool", default=True),
     )
 

tests/sanity/ignore-2.15.txt

@@ -952,4 +952,5 @@ plugins/modules/ospf6interface.py validate-modules:missing-gplv3-license # We us
 plugins/modules/ospf6router.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfrouter.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfinterface.py validate-modules:missing-gplv3-license # We use MIT license
-plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/nslaslicense_offline.py validate-modules:missing-gplv3-license # We use MIT license

tests/sanity/ignore-2.16.txt

@@ -952,4 +952,5 @@ plugins/modules/ospf6interface.py validate-modules:missing-gplv3-license # We us
 plugins/modules/ospf6router.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfrouter.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfinterface.py validate-modules:missing-gplv3-license # We use MIT license
-plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/nslaslicense_offline.py validate-modules:missing-gplv3-license # We use MIT license

tests/sanity/ignore-2.17.txt

@@ -952,4 +952,5 @@ plugins/modules/ospf6interface.py validate-modules:missing-gplv3-license # We us
 plugins/modules/ospf6router.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfrouter.py validate-modules:missing-gplv3-license # We use MIT license
 plugins/modules/ospfinterface.py validate-modules:missing-gplv3-license # We use MIT license
-plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/bgprouter.py validate-modules:missing-gplv3-license # We use MIT license
+plugins/modules/nslaslicense_offline.py validate-modules:missing-gplv3-license # We use MIT license