Changes done correct datatype issues in OpenAPi which is causing idempotency issues due to mismatch in payload and responseload in APIs

Author: Shiva Shankar Vaddepally

README-new.md

@@ -0,0 +1,162 @@
+# NetScaler ADC Collection
+
+## Description
+The collection provides Ansible modules to configure and manage NetScaler ADC appliances. The modules are written using the [NITRO API](https://developer-docs.netscaler.com/en-us/adc-nitro-api/current-release.html). The modules are idempotent and can be used to configure the NetScaler ADC appliances in a declarative manner.
+
+## Requirements
+
+### Ansible version compatibility
+Tested with Ansible Core >=2.15 versions.
+
+### Python version compatibility
+Tested with Python >=3.11
+
+## Installation
+
+### via Ansible-galaxy
+The netscaler.adc collection can be installed with the Ansible Galaxy command-line tool:
+
+```bash
+ansible-galaxy collection install netscaler.adc
+```
+
+### via github (to have the latest updated which are yet to be released in ansible-galaxy)
+
+```bash
+ansible-galaxy collection install "git+https://github.com/netscaler/ansible-collection-netscaleradc.git" [--force]
+```
+
+> `--force` option is required if you have already installed the collection via ansible-galaxy. This will overwrite the existing collection with the latest collection from github.
+
+To verify the installation, run the following command:
+
+```bash
+ansible-galaxy collection list netscaler.adc
+```
+
+The above command should display the below output:
+
+```text
+
+# /Users/netscaleruser/.ansible/collections/ansible_collections
+Collection    Version
+------------- -------
+netscaler.adc 2.8.x
+```
+
+## Usecases
+
+The modules can be called by their Fully Qualified Collection Name (FQCN) such as `netscaler.adc.lbvserver`, or by their short name `netscaler.adc` if the collection is listed under the playbook's `collections` attribute:
+
+### Usecase by FQCN
+```yaml
+---
+- name: Sample lbvserver playbook
+  hosts: demo_netscalers
+  gather_facts: false
+  tasks:
+    - name: Configure lbvserver
+      delegate_to: localhost
+      netscaler.adc.lbvserver:
+        nsip: "{{ nsip }}"
+        nitro_user: "{{ nitro_user }}"
+        nitro_pass: "{{ nitro_pass }}"
+        nitro_protocol: "{{ nitro_protocol }}"
+        validate_certs: false
+        save_config: false
+        state: present
+        name: lb_dns_01
+        servicetype: HTTP
+```
+
+### Usecase by declaring collection
+
+```yaml
+---
+- name: Sample lbvserver playbook
+  hosts: demo_netscalers
+  gather_facts: false
+  collections:
+      - netscaler.adc
+  tasks:
+    - name: Configure lbvserver
+      delegate_to: localhost
+      lbvserver:
+        nsip: "{{ nsip }}"
+        nitro_user: "{{ nitro_user }}"
+        nitro_pass: "{{ nitro_pass }}"
+        nitro_protocol: "{{ nitro_protocol }}"
+        validate_certs: false
+        save_config: false
+        name: lb_dns_01
+        servicetype: HTTP
+
+```
+### Usecase by `netscaler.adc.module_default` group 
+
+```yaml
+---
+- name: Sample Playbook to use module_defaults to specify common arguments
+  hosts: localhost
+  gather_facts: false
+  module_defaults:
+    group/netscaler.adc.default_args:
+      nsip: 10.10.10.10
+      nitro_user: nsroot
+      nitro_pass: verysecretpassword
+      nitro_protocol: http
+      validate_certs: false
+      save_config: false
+  tasks:
+    - name: Sample Task | ipset
+      delegate_to: localhost
+      netscaler.adc.lbvserver:
+        name: lb_dns_01
+        servicetype: HTTP
+```
+
+###  Authentication
+
+#### Authenticate to NetScaler via username and password
+
+Every module in the collection requires the user to authenticate to the NetScaler ADC appliance. To authenticate, provide the `nsip`, `nitro_user` and `nitro_pass` parameters directly or set them using environment variables `NETSCALER_NSIP`, `NETSCALER_NITRO_USER` and `NETSCALER_NITRO_PASS`.
+
+Refer to the [playbook_anatomy.md](https://github.com/netscaler/ansible-collection-netscaleradc/blob/c8c77cb4cb3905af8b90992bc55519f9a513ed08/playbook_anatomy.md#L4) and [examples](https://github.com/netscaler/ansible-collection-netscaleradc/tree/c8c77cb4cb3905af8b90992bc55519f9a513ed08/examples) directory for the sample playbooks.
+
+
+### Invocation
+
+The credentials of the netscaler can be provided either in the playbook by hardcoding or defining in a inventory.ini file.
+
+#### Execution command when hosts are declared in playbook:
+
+```
+ansible-playbook playbook.yaml [--verbose]
+```
+
+#### Execution command hosts are declared in an inventory file:
+
+```
+ansible-playbook playbook.yaml -i inventory.ini [--verbose]
+```
+
+## Testing
+The collection is tested using Github Actions. To know more about testing, please refer the [link]([https://github.com/netscaler/ansible-collection-netscaleradc/.github/workflow) to know more.
+
+## Contributing
+
+For external contributions, refer the [guidelines](https://github.com/netscaler/ansible-collection-netscaleradc/blob/c8c77cb4cb3905af8b90992bc55519f9a513ed08/CONTRIBUTING.md#L4).
+
+## Support
+For issues : [Issues](https://github.com/netscaler/ansible-collection-netscaleradc/issues)
+
+For discussions or feature requests: [Discussions or feature request](https://github.com/netscaler/ansible-collection-netscaleradc/issues)
+
+
+## Release Notes
+
+Please refer to the [link](https://github.com/netscaler/ansible-collection-netscaleradc/blob/0438f3253b2eca084760984b6564a0a7964a128d/CHANGELOG.md) for the release notes.
+
+## License Information
+
+The collection uses MIT License. You can refer the [link](https://github.com/netscaler/ansible-collection-netscaleradc/blob/0438f3253b2eca084760984b6564a0a7964a128d/LICENSE) to view license information.

examples/(null).yaml

@@ -0,0 +1,10 @@
+---
+- name: Sample (null) playbook
+  hosts: demo_netscalers
+  gather_facts: false
+  tasks:
+    - name: Configure (null)
+      delegate_to: localhost
+      netscaler.adc.(null):
+        state: present
+        command: rm /var/netscaler/ssl/crl.pem

examples/aaagroup.yaml

@@ -7,4 +7,4 @@
       delegate_to: localhost
       netscaler.adc.aaagroup:
         state: present
-        groupname: External
+        groupname: clt_scrgrp1

examples/aaagroup_vpnsessionpolicy_binding.yaml

@@ -7,7 +7,6 @@
       delegate_to: localhost
       netscaler.adc.aaagroup_vpnsessionpolicy_binding:
         state: present
-        groupname: External
-        policy: External_receiver_session_pol
-        priority: '110'
-        gotopriorityexpression: NEXT
+        groupname: group1
+        policy: vpn_sespol2
+        priority: '15'

examples/aaaldapparams.yaml

@@ -7,4 +7,4 @@
       delegate_to: localhost
       netscaler.adc.aaaldapparams:
         state: present
-        sectype: PLAINTEXT
+        serverip: 10.102.39.101

examples/aaaparameter.yaml

@@ -7,6 +7,4 @@
       delegate_to: localhost
       netscaler.adc.aaaparameter:
         state: present
-        maxaaausers: '4294967295'
-        aaasessionloglevel: DEBUG
-        aaadloglevel: ALERT
+        maxaaausers: '5'

examples/appflowaction.yaml

@@ -7,6 +7,7 @@
       delegate_to: localhost
       netscaler.adc.appflowaction:
         state: present
-        name: af_action_log_10.189.64.10_nop
+        name: af_action_v1_10.102.233.21
         collectors:
-          - af_collector_logstream_10.189.64.10
+          - af_collector_10.102.233.21
+        clientsidemeasurements: ENABLED

examples/appflowcollector.yaml

@@ -7,7 +7,5 @@
       delegate_to: localhost
       netscaler.adc.appflowcollector:
         state: present
-        name: af_collector_logstream_10.189.64.10
-        ipaddress: 10.189.64.10
-        port: 5557
-        transport: logstream
+        name: af_collector_10.102.233.21
+        ipaddress: 10.102.233.21

examples/appflowparam.yaml

@@ -9,12 +9,9 @@
         state: present
         templaterefresh: 3600
         httpurl: ENABLED
+        httpcookie: ENABLED
+        httpreferer: ENABLED
         httpmethod: ENABLED
         httphost: ENABLED
         httpuseragent: ENABLED
         httpcontenttype: ENABLED
-        cacheinsight: ENABLED
-        httpquerywithurl: ENABLED
-        metrics: ENABLED
-        events: ENABLED
-        observationpointid: '843103498'

examples/appflowpolicy.yaml

@@ -7,6 +7,6 @@
       delegate_to: localhost
       netscaler.adc.appflowpolicy:
         state: present
-        name: af_policy_act_log_10.189.64.10
+        name: af_policy_v1_10.102.233.21
         rule: 'true'
-        action: af_action_log_10.189.64.10_nop
+        action: af_action_v1_10.102.233.21