CodeQL Nags

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/dsl/SelectDSL.java

@@ -163,6 +163,7 @@ public SelectDSL orderBy(Collection<? extends SortSpecification> columns) {
         return this;
     }
 
+    @Override
     public SelectDSL groupBy(Collection<? extends BasicColumn> columns) {
         currentQueryValues.builder.withGroupByModel(GroupByModel.of(columns));
         return this;

src/main/java/org/mybatis/dynamic/sql/select/QueryExpressionDSL.java

@@ -157,6 +157,7 @@ public R build() {
         return selectDSL.build();
     }
 
+    @Override
     public QueryExpressionDSL<R> groupBy(Collection<? extends BasicColumn> columns) {
         groupByModel = GroupByModel.of(columns);
         return this;
@@ -252,6 +253,7 @@ public SelectDSL<R> orderBy(Collection<? extends SortSpecification> columns) {
             return QueryExpressionDSL.this.orderBy(columns);
         }
 
+        @Override
         public QueryExpressionDSL<R> groupBy(Collection<? extends BasicColumn> columns) {
             return QueryExpressionDSL.this.groupBy(columns);
         }
@@ -340,6 +342,7 @@ public QueryExpressionWhereBuilder applyWhere(WhereApplier whereApplier) {
             return QueryExpressionDSL.this.applyWhere(whereApplier);
         }
 
+        @Override
         public QueryExpressionDSL<R> groupBy(Collection<? extends BasicColumn> columns) {
             return QueryExpressionDSL.this.groupBy(columns);
         }

src/test/java/examples/joins/JoinMapperV2Test.java

@@ -58,12 +58,13 @@ class JoinMapperV2Test {
     @BeforeEach
     void setup() throws Exception {
         Class.forName(JDBC_DRIVER);
-        InputStream is = getClass().getResourceAsStream("/examples/joins/CreateJoinDB.sql");
-        assert is != null;
-        try (Connection connection = DriverManager.getConnection(JDBC_URL, "sa", "")) {
-            ScriptRunner sr = new ScriptRunner(connection);
-            sr.setLogWriter(null);
-            sr.runScript(new InputStreamReader(is));
+        try (InputStream is = getClass().getResourceAsStream("/examples/joins/CreateJoinDB.sql")) {
+            assert is != null;
+            try (Connection connection = DriverManager.getConnection(JDBC_URL, "sa", "")) {
+                ScriptRunner sr = new ScriptRunner(connection);
+                sr.setLogWriter(null);
+                sr.runScript(new InputStreamReader(is));
+            }
         }
 
         UnpooledDataSource ds = new UnpooledDataSource(JDBC_DRIVER, JDBC_URL, "sa", "");

src/test/java/examples/simple/PersonMapperV2Test.java

@@ -79,12 +79,13 @@ class PersonMapperV2Test {
     @BeforeEach
     void setup() throws Exception {
         Class.forName(JDBC_DRIVER);
-        InputStream is = getClass().getResourceAsStream("/examples/simple/CreateSimpleDB.sql");
-        assert is != null;
-        try (Connection connection = DriverManager.getConnection(JDBC_URL, "sa", "")) {
-            ScriptRunner sr = new ScriptRunner(connection);
-            sr.setLogWriter(null);
-            sr.runScript(new InputStreamReader(is));
+        try (InputStream is = getClass().getResourceAsStream("/examples/simple/CreateSimpleDB.sql")) {
+            assert is != null;
+            try (Connection connection = DriverManager.getConnection(JDBC_URL, "sa", "")) {
+                ScriptRunner sr = new ScriptRunner(connection);
+                sr.setLogWriter(null);
+                sr.runScript(new InputStreamReader(is));
+            }
         }
 
         UnpooledDataSource ds = new UnpooledDataSource(JDBC_DRIVER, JDBC_URL, "sa", "");