Replaced slice pointer arguments with slice arguments where slice modification is not required

Author: mpraski

dbscan.go

@@ -19,7 +19,7 @@ type dbscanClusterer struct {
 	j          chan *rangeJob
 	m          *sync.Mutex
 	w          *sync.WaitGroup
-	p          *[]float64
+	p          []float64
 	r          *[]int
 
 	// visited points
@@ -194,7 +194,7 @@ func (c *dbscanClusterer) nearest(p int, l *int, r *[]int) {
 
 	*r = (*r)[:0]
 
-	c.p = &c.d[p]
+	c.p = c.d[p]
 	c.r = r
 
 	c.w.Add(c.s)
@@ -240,7 +240,7 @@ func (c *dbscanClusterer) endNearestWorkers() {
 func (c *dbscanClusterer) nearestWorker() {
 	for j := range c.j {
 		for i := j.a; i < j.b; i++ {
-			if c.distance(*c.p, c.d[i]) < c.eps {
+			if c.distance(c.p, c.d[i]) < c.eps {
 				c.m.Lock()
 				*c.r = append(*c.r, i)
 				c.m.Unlock()

optics.go

@@ -30,7 +30,7 @@ type opticsClusterer struct {
 	c             chan *clusterJob
 	m             *sync.Mutex
 	w             *sync.WaitGroup
-	p             *[]float64
+	p             []float64
 	r             *[]int
 
 	// visited points
@@ -190,10 +190,10 @@ func (c *opticsClusterer) run() {
 
 		c.so = append(c.so, i)
 
-		if d = c.coreDistance(i, l, &ns); d != 0 {
+		if d = c.coreDistance(i, l, ns); d != 0 {
 			q = newPriorityQueue(l)
 
-			c.update(i, d, l, &ns, &q)
+			c.update(i, d, l, ns, &q)
 
 			for q.NotEmpty() {
 				p = q.Pop().(*pItem)
@@ -204,46 +204,46 @@ func (c *opticsClusterer) run() {
 
 				c.so = append(c.so, p.v)
 
-				if d = c.coreDistance(p.v, l, &nss); d != 0 {
-					c.update(p.v, d, l, &nss, &q)
+				if d = c.coreDistance(p.v, l, nss); d != 0 {
+					c.update(p.v, d, l, nss, &q)
 				}
 			}
 		}
 	}
 }
 
-func (c *opticsClusterer) coreDistance(p int, l int, r *[]int) float64 {
+func (c *opticsClusterer) coreDistance(p int, l int, r []int) float64 {
 	if l < c.minpts {
 		return 0
 	}
 
-	var d, m float64 = 0, c.distance(c.d[p], c.d[(*r)[0]])
+	var d, m float64 = 0, c.distance(c.d[p], c.d[r[0]])
 
 	for i := 1; i < l; i++ {
-		if d = c.distance(c.d[p], c.d[(*r)[i]]); d > m {
+		if d = c.distance(c.d[p], c.d[r[i]]); d > m {
 			m = d
 		}
 	}
 
 	return m
 }
 
-func (c *opticsClusterer) update(p int, d float64, l int, r *[]int, q *priorityQueue) {
+func (c *opticsClusterer) update(p int, d float64, l int, r []int, q *priorityQueue) {
 	for i := 0; i < l; i++ {
-		if !c.v[(*r)[i]] {
-			m := math.Max(d, c.distance(c.d[p], c.d[(*r)[i]]))
+		if !c.v[r[i]] {
+			m := math.Max(d, c.distance(c.d[p], c.d[r[i]]))
 
-			if c.re[(*r)[i]] == nil {
+			if c.re[r[i]] == nil {
 				item := &pItem{
-					v: (*r)[i],
+					v: r[i],
 					p: m,
 				}
 
-				c.re[(*r)[i]] = item
+				c.re[r[i]] = item
 
 				q.Push(item)
-			} else if m < c.re[(*r)[i]].p {
-				q.Update(c.re[(*r)[i]], c.re[(*r)[i]].v, m)
+			} else if m < c.re[r[i]].p {
+				q.Update(c.re[r[i]], c.re[r[i]].v, m)
 			}
 		}
 	}
@@ -474,7 +474,7 @@ func (c *opticsClusterer) nearest(p int, l *int, r *[]int) {
 
 	*r = (*r)[:0]
 
-	c.p = &c.d[p]
+	c.p = c.d[p]
 	c.r = r
 
 	c.w.Add(c.s)
@@ -520,7 +520,7 @@ func (c *opticsClusterer) endNearestWorkers() {
 func (c *opticsClusterer) nearestWorker() {
 	for j := range c.j {
 		for i := j.a; i < j.b; i++ {
-			if c.distance(*c.p, c.d[i]) < c.eps {
+			if c.distance(c.p, c.d[i]) < c.eps {
 				c.m.Lock()
 				*c.r = append(*c.r, i)
 				c.m.Unlock()